Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NativeScript/nativescript-dev-webpack
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.5.0
Choose a base ref
...
head repository: NativeScript/nativescript-dev-webpack
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: release
Choose a head ref
  • 11 commits
  • 5 files changed
  • 6 contributors

Commits on Feb 12, 2020

  1. fix: `The provided Android NDK is vnull while the recommended one is …

    …v21.0.6113669` error in some cases
    DimitarTachev committed Feb 12, 2020
    Copy the full SHA
    23aa6c5 View commit details
  2. chore: bump version

    DimitarTachev committed Feb 12, 2020
    Copy the full SHA
    45ef004 View commit details
  3. Merge pull request #1125 from NativeScript/tachev/fix-ndk-warning

    fix: `The provided Android NDK is vnull while the recommended one is v21.0.6113669` error in some cases
    Dimitar Tachev authored Feb 12, 2020
    Copy the full SHA
    25238ff View commit details

Commits on Feb 21, 2020

  1. Copy the full SHA
    6e145a4 View commit details
  2. Copy the full SHA
    55b56c8 View commit details
  3. Copy the full SHA
    a04c0f8 View commit details
  4. fix: AOT compilation of multiple workers should work

    In case you have multiple TypeScript workers in Angular app, trying to build the project with AOT fails. The fix is in 0.11.0 version in nativescript-worker-loader, so update it to resolve the issue.
    rosen-vladimirov committed Feb 21, 2020
    Copy the full SHA
    af5cb84 View commit details
  5. Merge pull request #1128 from NativeScript/vladimirov/update-worker-l…

    …oader
    
    fix: AOT compilation of multiple workers should work
    rosen-vladimirov authored Feb 21, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    661c3c4 View commit details
  6. Merge pull request #1127 from NativeScript/vmutafov/kotlinjs

    feat: Add initial support for KotlinJS
    rosen-vladimirov authored Feb 21, 2020
    Copy the full SHA
    39cb24d View commit details

Commits on Feb 25, 2020

  1. Copy the full SHA
    dea6def View commit details
  2. Merge pull request #1129 from NativeScript/release-1.5.1

    release: cut 1.5.1 release
    dtopuzov authored Feb 25, 2020
    Copy the full SHA
    40b64c9 View commit details
Showing with 31 additions and 7 deletions.
  1. +18 −0 CHANGELOG.md
  2. +1 −1 bundle-config-loader.ts
  3. +5 −3 index.js
  4. +2 −2 package.json
  5. +5 −1 snapshot/android/snapshot-generator.js
18 changes: 18 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,21 @@
<a name="1.5.1"></a>
## [1.5.1](https://github.com/NativeScript/nativescript-dev-webpack/compare/v1.5.0...v1.5.1) (2020-02-25)


### Bug Fixes

* `The provided Android NDK is vnull while the recommended one is v21.0.6113669` error in some cases ([23aa6c5](https://github.com/NativeScript/nativescript-dev-webpack/commit/23aa6c5))
* AOT compilation of multiple workers should work ([af5cb84](https://github.com/NativeScript/nativescript-dev-webpack/commit/af5cb84))
* replace extension coming from package.json ([a04c0f8](https://github.com/NativeScript/nativescript-dev-webpack/commit/a04c0f8))


### Features

* Add .kt extension to known entry types ([55b56c8](https://github.com/NativeScript/nativescript-dev-webpack/commit/55b56c8))
* Add .kt extension to known ones ([6e145a4](https://github.com/NativeScript/nativescript-dev-webpack/commit/6e145a4))



<a name="1.5.0"></a>
# [1.5.0](https://github.com/NativeScript/nativescript-dev-webpack/compare/1.4.1...1.5.0) (2020-02-04)

2 changes: 1 addition & 1 deletion bundle-config-loader.ts
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ import { getOptions } from "loader-utils";
import * as escapeRegExp from "escape-string-regexp";

// Matches all source, markup and style files that are not in App_Resources and in tests folder
const defaultMatch = "(?<!\\bApp_Resources\\b.*)(?<!\\.\\/\\btests\\b\\/.*?)\\.(xml|css|js|(?<!\\.d\\.)ts|(?<!\\b_[\\w-]*\\.)scss)$";
const defaultMatch = "(?<!\\bApp_Resources\\b.*)(?<!\\.\\/\\btests\\b\\/.*?)\\.(xml|css|js|kt|(?<!\\.d\\.)ts|(?<!\\b_[\\w-]*\\.)scss)$";

const loader: loader.Loader = function (source, map) {
let {
8 changes: 5 additions & 3 deletions index.js
Original file line number Diff line number Diff line change
@@ -79,12 +79,14 @@ exports.getEntryModule = function (appDirectory, platform) {
const entry = getPackageJsonEntry(appDirectory);

const tsEntryPath = path.resolve(appDirectory, `${entry}.ts`);
const ktEntryPath = path.resolve(appDirectory, `${entry}.kt`);
const jsEntryPath = path.resolve(appDirectory, `${entry}.js`);
let entryExists = existsSync(tsEntryPath) || existsSync(jsEntryPath);
let entryExists = existsSync(tsEntryPath) || existsSync(ktEntryPath) || existsSync(jsEntryPath);
if (!entryExists && platform) {
const platformTsEntryPath = path.resolve(appDirectory, `${entry}.${platform}.ts`);
const platformKtEntryPath = path.resolve(appDirectory, `${entry}.${platform}.kt`);
const platformJsEntryPath = path.resolve(appDirectory, `${entry}.${platform}.js`);
entryExists = existsSync(platformTsEntryPath) || existsSync(platformJsEntryPath);
entryExists = existsSync(platformTsEntryPath) || existsSync(platformKtEntryPath) || existsSync(platformJsEntryPath);
}

if (!entryExists) {
@@ -208,7 +210,7 @@ function getPackageJsonEntry(appDirectory) {
throw new Error(`${appDirectory}/package.json must contain a 'main' attribute!`);
}

return entry.replace(/\.js$/i, "");
return entry.replace(/\.js$/i, "").replace(/\.kt$/i, "");
}

function verifyEntryModuleDirectory(appDirectory) {
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "nativescript-dev-webpack",
"version": "1.5.0",
"version": "1.5.1",
"main": "index",
"description": "",
"homepage": "http://www.telerik.com",
@@ -58,7 +58,7 @@
"loader-utils": "^1.2.3",
"minimatch": "3.0.4",
"nativescript-hook": "0.2.4",
"nativescript-worker-loader": "~0.10.0",
"nativescript-worker-loader": "~0.11.0",
"properties-reader": "0.3.1",
"proxy-lib": "0.4.0",
"raw-loader": "~0.5.1",
6 changes: 5 additions & 1 deletion snapshot/android/snapshot-generator.js
Original file line number Diff line number Diff line change
@@ -400,7 +400,11 @@ SnapshotGenerator.prototype.buildCSource = function (androidArch, blobInputDir,
}

SnapshotGenerator.prototype.getRecommendedNdkWarning = function (localNdkRevision, recommendedAndroidNdkRevision) {
return `The provided Android NDK is v${localNdkRevision} while the recommended one is v${recommendedAndroidNdkRevision}`;
if (localNdkRevision) {
return `The provided Android NDK is v${localNdkRevision} while the required one is v${recommendedAndroidNdkRevision}`;
} else {
return `The provided Android NDK version is different than the required one - v${recommendedAndroidNdkRevision}`;
}
}

SnapshotGenerator.prototype.runMksnapshotTool = function (tool, mksnapshotParams, inputFile, snapshotInDocker, snapshotToolsPath, buildCSource) {