Optional dictionary for polymorphic associations

Author: vovimayhem

lib/fast_jsonapi/serialization_core.rb

@@ -26,19 +26,25 @@ def ids_hash(ids, record_type)
         id_hash(ids, record_type) # ids variable is just a single id here
       end
 
-      def id_hash_from_record(record)
-        { id: record.id.to_s, type: record.class.name.underscore.to_sym }
+      def id_hash_from_record(record, record_types = nil)
+        record_type = record_types.respond_to?(:key) ? record_types[record.class] : nil
+        { id: record.id.to_s, type: (record_type || record.class.name.underscore.to_sym) }
       end
 
       def ids_hash_from_record_and_relationship(record, relationship)
+        polymorphic = relationship[:polymorphic]
+
         return ids_hash(record.send(relationship[:id_method_name]), relationship[:record_type]) \
-          unless relationship[:polymorphic]
+          unless polymorphic
 
         object_method_name = relationship.fetch(:object_method_name, relationship[:name])
         return unless associated_object = record.send(object_method_name)
 
-        return id_hash_from_record(associated_object) unless associated_object.respond_to? :map
-        associated_object.map { |object| id_hash_from_record(object) }
+        return associated_object.map do |object|
+          id_hash_from_record object, polymorphic
+        end if associated_object.respond_to? :map
+        
+        id_hash_from_record associated_object, polymorphic
       end
 
       def attributes_hash(record)

spec/lib/object_serializer_performance_spec.rb

@@ -112,7 +112,7 @@ def run_json_benchmark(message, movie_count, our_serializer, ams_serializer)
 
   context 'when comparing with AMS 0.10.x and with polymorphic has_many' do
     [1, 25, 250, 1000].each do |group_count|
-      speed_factor = 5
+      speed_factor = 25
       it "should serialize #{group_count} records at least #{speed_factor} times faster than AMS" do
         ams_groups = build_ams_groups(group_count)
         groups = build_groups(group_count)

spec/shared/contexts/group_context.rb

@@ -22,7 +22,7 @@ class GroupSerializer
       include FastJsonapi::ObjectSerializer
       set_type :group
       attributes :name
-      has_many :groupees, polymorphic: true
+      has_many :groupees, polymorphic: { Person => :person, Group => :group }
     end
   end