Merge pull request #4396 from oleibman/stan2lv901

Phpstan Level 9 - Part 1 of Many

Author: oleibman

CHANGELOG.md

@@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org).
 ### Changed
 
 - Phpstan Version 2. [PR #4384](https://github.com/PHPOffice/PhpSpreadsheet/pull/4384)
+- Start migration to Phpstan level 9. [PR #4396](https://github.com/PHPOffice/PhpSpreadsheet/pull/4396)
 
 ### Moved
 

infra/DocumentGenerator.php

@@ -52,6 +52,7 @@ private static function tableRow(array $lengths, ?array $values = null): string
         return rtrim($result, ' ');
     }
 
+    /** @param array<int,string>|scalar $functionCall */
     private static function getPhpSpreadsheetFunctionText(mixed $functionCall): string
     {
         if (is_string($functionCall)) {

infra/LocaleGenerator.php

@@ -283,7 +283,7 @@ protected function mapLanguageColumns(Worksheet $translationWorksheet): array
             foreach ($cells as $cell) {
                 if ($this->localeCanBeSupported($translationWorksheet, $cell)) {
                     $languageNameMap[$cell->getColumn()] = $cell->getValue();
-                    $this->log($cell->getColumn() . ' -> ' . $cell->getValue());
+                    $this->log($cell->getColumn() . ' -> ' . $cell->getValueString());
                 }
             }
         }
@@ -316,7 +316,7 @@ protected function mapErrorCodeRows(): void
             $cells->setIterateOnlyExistingCells(true);
             foreach ($cells as $cell) {
                 if ($cell->getValue() != '') {
-                    $this->log($cell->getRow() . ' -> ' . $cell->getValue());
+                    $this->log($cell->getRow() . ' -> ' . $cell->getValueString());
                     $this->errorCodeMap[$cell->getValue()] = $cell->getRow();
                 }
             }
@@ -334,7 +334,7 @@ protected function mapFunctionNameRows(): void
             foreach ($cells as $cell) {
                 if ($this->isFunctionCategoryEntry($cell)) {
                     if (!empty($cell->getValue())) {
-                        $this->log('CATEGORY: ' . $cell->getValue());
+                        $this->log('CATEGORY: ' . $cell->getValueString());
                         $this->functionNameMap[$cell->getValue()] = $cell->getRow();
                     }
 
@@ -345,7 +345,7 @@ protected function mapFunctionNameRows(): void
                         $this->log($cell->getRow() . ' -> ' . ($cell->getValue() ? 'TRUE' : 'FALSE'));
                         $this->functionNameMap[($cell->getValue() ? 'TRUE' : 'FALSE')] = $cell->getRow();
                     } else {
-                        $this->log($cell->getRow() . ' -> ' . $cell->getValue());
+                        $this->log($cell->getRow() . ' -> ' . $cell->getValueString());
                         $this->functionNameMap[$cell->getValue()] = $cell->getRow();
                     }
                 }