Allow deleting alert_grouping_parameters with a time_window equal to 86400

cjgajard · cjgajard · commit 34e33029d8c0 · 2025-06-27T09:59:40.000-04:00
diff --git a/pagerduty/resource_pagerduty_service.go b/pagerduty/resource_pagerduty_service.go
@@ -352,7 +352,7 @@ func customizePagerDutyServiceDiff(context context.Context, diff *schema.Resourc
 		if agpType == "content_based" && (aggregateVal == "" || len(fieldsVal) == 0) {
 			return fmt.Errorf("When using Alert grouping parameters configuration of type \"content_based\" is in use, attributes \"aggregate\" and \"fields\" are required")
 		}
-		if timeWindowVal == 86400 && agpType != "content_based" {
+		if timeWindowVal == 86400 && agpType != "" && agpType != "content_based" {
 			return fmt.Errorf("Alert grouping parameters configuration attribute \"time_window\" with a value of 86400 is only supported by \"content-based\" type Alert Grouping")
 		}
 		if (aggregateVal != "" || len(fieldsVal) > 0) && (agpType != "" && hasChangeAgpType && agpType != "content_based") {

Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,7 @@ func customizePagerDutyServiceDiff(context context.Context, diff *schema.Resourc`
`352`	`352`	`if agpType == "content_based" && (aggregateVal == "" \|\| len(fieldsVal) == 0) {`
`353`	`353`	`return fmt.Errorf("When using Alert grouping parameters configuration of type \"content_based\" is in use, attributes \"aggregate\" and \"fields\" are required")`
`354`	`354`	`}`
`355`		`- if timeWindowVal == 86400 && agpType != "content_based" {`
	`355`	`+ if timeWindowVal == 86400 && agpType != "" && agpType != "content_based" {`
`356`	`356`	`return fmt.Errorf("Alert grouping parameters configuration attribute \"time_window\" with a value of 86400 is only supported by \"content-based\" type Alert Grouping")`
`357`	`357`	`}`
`358`	`358`	`if (aggregateVal != "" \|\| len(fieldsVal) > 0) && (agpType != "" && hasChangeAgpType && agpType != "content_based") {`