Skip to content

Commit 1f993cf

Browse files
committed
Explicitly depend on babel plugin
Running the latest version of Storybook logged a warning during building: One of your dependencies, babel-preset-react-app, is importing the "@babel/plugin-proposal-private-property-in-object" package without declaring it in its dependencies. This is currently working because "@babel/plugin-proposal-private-property-in-object" is already in your node_modules folder for unrelated reasons, but it may break at any time. babel-preset-react-app is part of the create-react-app project, which is not maintianed anymore. It is thus unlikely that this bug will ever be fixed. Add "@babel/plugin-proposal-private-property-in-object" to your devDependencies to work around this error. This will make this message go away. As the warning indicates, this is a known issue in create-react-app[1], which was actually fixed[2], but there has not been a release with that fix. Add the plugin to our devDependencies to work around the issue. Long term, we need to figure out what to do about create-react-app. [1] facebook/create-react-app#13325 [2] facebook/create-react-app#12364
1 parent d12f3f2 commit 1f993cf

File tree

2 files changed

+23
-3
lines changed

2 files changed

+23
-3
lines changed

package-lock.json

Lines changed: 22 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
"web-vitals": "^3.4.0"
1616
},
1717
"devDependencies": {
18+
"@babel/plugin-proposal-private-property-in-object": "^7.21.11",
1819
"@storybook/addon-essentials": "^7.3.2",
1920
"@storybook/addon-interactions": "^7.3.2",
2021
"@storybook/addon-links": "^7.3.2",

0 commit comments

Comments
 (0)