Skip to content

Commit 0df322c

Browse files
authored
Use newer ditto/update python (#240)
* feat: use newer ditto/update python * fix: use right executor * sec: fix deps
1 parent af1cc9a commit 0df322c

File tree

4 files changed

+8
-19
lines changed

4 files changed

+8
-19
lines changed

.circleci/config.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,29 @@
11
version: 2.1
22

33
executors:
4-
python36:
4+
python3:
55
docker:
6-
- image: cimg/python:3.6.15
6+
- image: cimg/python:3.12.3
77

88
commands:
99
ditto-transform:
1010
description: Run Ditto in order to transform the BASE_URL instead of http://localhost
1111
steps:
1212
- run:
13-
name: Install requirements.txt
14-
command: pip install --user -r requirements.txt
13+
name: Install Ditto
14+
command: pip install --user 'pokeapi-ditto==1.0.2'
1515
- run:
1616
name: Transform api-data's JSON files to have the correct BASE_URL instead of http://localhost
1717
command: bash -x scripts/transform.sh
1818

1919
jobs:
2020
test:
21-
executor: python36
21+
executor: python3
2222
steps:
2323
- checkout
2424
- ditto-transform
2525
build-and-deploy:
26-
executor: python36
26+
executor: python3
2727
steps:
2828
- checkout
2929
- ditto-transform
File renamed without changes.

requirements.txt

Lines changed: 0 additions & 11 deletions
This file was deleted.

updater/cmd.bash

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ git branch -D "$BRANCH_NAME" || true
3434
git branch "$BRANCH_NAME"
3535
git checkout "$BRANCH_NAME"
3636

37-
pip install -r requirements.txt
38-
rm -r ./data
37+
pip install 'pokeapi-ditto==1.0.2'
38+
rm -rf ./data
3939
ditto clone --src-url http://localhost/ --dest-dir ./data
4040
# (╯°□°)╯ *always* assume magikarp failed and grab it again #clowntown
4141
ditto clone --src-url http://localhost/ --dest-dir ./data --select pokemon/129

0 commit comments

Comments
 (0)