Update packages with a VS Code engine bump to 1.96

With new string casts to quiet new warnings.

Author: andyleejordan

docs/development.md

@@ -36,9 +36,8 @@ dictates which version of Node.js the extension is eventually run with. This
 lets us finally update our `@types/node` development dependency to match, our
 developer machines if necessary, and the CI and OneBranch pipeline tasks.
 
-[`vscodeVersion`]: https://github.com/microsoft/azuredatastudio/blob/4970733324ef8254b7c22a5dc55af7f8a1dea93f/product.json#L50
-[`electron`]: https://github.com/microsoft/vscode/blob/384ff7382de624fb94dbaf6da11977bba1ecd427/package.json#L159
-[Electron]: https://www.electronjs.org/blog/electron-30-0
+[`electron`]: https://github.com/microsoft/vscode/blob/138f619c86f1199955d53b4166bef66ef252935c/package.json#L156
+[Electron]: https://releases.electronjs.org/release/v32.2.6
 [Node.js]: https://nodejs.org/en/download/package-manager
 
 ### Building the Code
@@ -65,7 +64,7 @@ To debug the extension use one of the provided `Launch Extension` debug configur
 
 All three templates use pre-launch tasks to build the code, and support automatic restart of the extension host on changes to the Extension source code. [Hot Reload](https://devblogs.microsoft.com/dotnet/introducing-net-hot-reload/) is also enabled for PowerShell Editor Services.
 
-> [!WARNING]  
+> [!WARNING]
 > There is a current limitation that, if you restart the extension/extension host or it is restarted due to a extension code change, the editor services attachment will be disconnected due to the PSES terminal being terminated, and you will either need to restart the debug session completely, or do a manual build of PSES and run the `Attach to Editor Services` debug launch manually.
 
 Try the `powershell.developer.editorServicesWaitForDebugger` setting to ensure that you are fully attached before the extension startup process continues.

package-lock.json

@@ -6,7 +6,7 @@
   "publisher": "ms-vscode",
   "description": "Develop PowerShell modules, commands and scripts in Visual Studio Code!",
   "engines": {
-    "vscode": "^1.94.0"
+    "vscode": "^1.96.0"
   },
   "author": "Microsoft Corporation",
   "license": "SEE LICENSE IN LICENSE.txt",
@@ -75,30 +75,30 @@
   "optionalDependencies": {
     "@types/mocha": "^10.0.10",
     "@types/mock-fs": "^4.13.4",
-    "@types/node": "^20.17.9",
+    "@types/node": "^20.18.1",
     "@types/node-fetch": "^2.6.12",
     "@types/rewire": "^2.5.30",
     "@types/semver": "^7.5.8",
     "@types/sinon": "^17.0.3",
     "@types/ungap__structured-clone": "^1.2.0",
     "@types/uuid": "^9.0.8",
-    "@types/vscode": "~1.94.0",
-    "@typescript-eslint/eslint-plugin": "^8.17.0",
-    "@typescript-eslint/parser": "^8.17.0",
-    "@ungap/structured-clone": "^1.2.0",
+    "@types/vscode": "~1.96.0",
+    "@typescript-eslint/eslint-plugin": "^8.20.0",
+    "@typescript-eslint/parser": "^8.20.0",
+    "@ungap/structured-clone": "^1.2.1",
     "@vscode/debugprotocol": "^1.68.0",
     "@vscode/test-electron": "^2.4.1",
     "eslint": "^8.57.0",
     "eslint-plugin-header": "^3.1.1",
-    "glob": "^11.0.0",
+    "glob": "^11.0.1",
     "mocha": "^10.8.2",
     "mocha-explorer-launcher-scripts": "^0.4.0",
     "mocha-multi-reporters": "^1.5.1",
     "mock-fs": "^5.4.1",
     "rewire": "^7.0.0",
     "sinon": "^18.0.1",
     "source-map-support": "^0.5.21",
-    "typescript": "^5.7.2"
+    "typescript": "^5.7.3"
   },
   "extensionDependencies": [
     "vscode.powershell"

package.json

@@ -17,8 +17,16 @@ export class GenerateBugReportFeature implements vscode.Disposable {
                 "labels=Issue-Bug",
                 "template=bug-report.yml",
                 "powershell-version=" + this.getRuntimeInfo(),
-                "vscode-version=" + vscode.version + "\n" + process.arch,
-                "extension-version=" + sessionManager.Publisher + "." + sessionManager.HostName + "@" + sessionManager.HostVersion,
+                "vscode-version=" +
+                    vscode.version +
+                    "\n" +
+                    (process.arch as string),
+                "extension-version=" +
+                    sessionManager.Publisher +
+                    "." +
+                    sessionManager.HostName +
+                    "@" +
+                    sessionManager.HostVersion,
             ];
             const url = vscode.Uri.parse(issuesUrl + encodeURIComponent(params.join("&")));
             await vscode.env.openExternal(url);

src/features/GenerateBugReport.ts

@@ -16,7 +16,7 @@ export class OpenInISEFeature implements vscode.Disposable {
 
             const document = editor.document;
             const uri = document.uri;
-            let ISEPath = process.env.windir ?? "C:\\Windows";
+            let ISEPath: string = process.env.windir ?? "C:\\Windows";
 
             if (process.env.PROCESSOR_ARCHITEW6432 !== undefined) {
                 ISEPath += "\\Sysnative";

src/features/OpenInISE.ts

@@ -79,10 +79,10 @@ let additionalPowerShellExes: Record<string, string>;
 let successAdditionalTestCases: ITestPlatformSuccessCase[];
 
 if (process.platform === "win32") {
-    const msixAppDir = path.join(process.env.LOCALAPPDATA!, "Microsoft", "WindowsApps");
+    const msixAppDir = path.join(process.env.LOCALAPPDATA, "Microsoft", "WindowsApps");
     const pwshMsixPath = path.join(msixAppDir, "Microsoft.PowerShell_8wekyb3d8bbwe", "pwsh.exe");
     const pwshPreviewMsixPath = path.join(msixAppDir, "Microsoft.PowerShellPreview_8wekyb3d8bbwe", "pwsh.exe");
-    const pwshDailyDir = path.join(process.env.LOCALAPPDATA!, "Microsoft", "powershell-daily");
+    const pwshDailyDir = path.join(process.env.LOCALAPPDATA, "Microsoft", "powershell-daily");
     const pwshDailyPath = path.join(pwshDailyDir, "pwsh.exe");
 
     successTestCases = [

test/core/platform.test.ts

@@ -19,7 +19,7 @@ function runTestsInner(testsRoot: string): Promise<void> {
     console.log(`\n\n=====\nTest Runner START\n${testsRoot}\n=====`);
 
     /** Passed from RunTests */
-    const rootDir = process.env.__TEST_EXTENSION_DEVELOPMENT_PATH;
+    const rootDir: string = process.env.__TEST_EXTENSION_DEVELOPMENT_PATH;
     if (!rootDir) {
         throw new Error("Missing environment variable __TEST_EXTENSIONDEVELOPMENTPATH, this is probably a bug in runTests.ts");
     }

test/runTestsInner.ts

@@ -8,6 +8,7 @@
       "ES2022",
       "DOM"
     ],
+    "types": [ "node" ],
     "sourceMap": true,
     "rootDir": ".",
     "strict": true,