Skip to content

Commit 14b086b

Browse files
authored
7908 drop python 3.8 (#7909)
Fix #7908 ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. Signed-off-by: YunLiu <[email protected]>
1 parent 9554f47 commit 14b086b

File tree

11 files changed

+20
-20
lines changed

11 files changed

+20
-20
lines changed

.github/workflows/cron-ngc-bundle.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@ jobs:
1818
runs-on: ubuntu-latest
1919
steps:
2020
- uses: actions/checkout@v4
21-
- name: Set up Python 3.8
21+
- name: Set up Python 3.9
2222
uses: actions/setup-python@v5
2323
with:
24-
python-version: '3.8'
24+
python-version: '3.9'
2525
- name: cache weekly timestamp
2626
id: pip-cache
2727
run: echo "datew=$(date '+%Y-%V')" >> $GITHUB_OUTPUT

.github/workflows/pythonapp-gpu.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
if [ ${{ matrix.environment }} = "PT110+CUDA111" ] || \
6363
[ ${{ matrix.environment }} = "PT113+CUDA116" ]
6464
then
65-
PYVER=3.8 PYSFX=3 DISTUTILS=python3-distutils && \
65+
PYVER=3.9 PYSFX=3 DISTUTILS=python3-distutils && \
6666
apt-get update && apt-get install -y --no-install-recommends \
6767
curl \
6868
pkg-config \

.github/workflows/pythonapp-min.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,10 @@ jobs:
3131
timeout-minutes: 40
3232
steps:
3333
- uses: actions/checkout@v4
34-
- name: Set up Python 3.8
34+
- name: Set up Python 3.9
3535
uses: actions/setup-python@v5
3636
with:
37-
python-version: '3.8'
37+
python-version: '3.9'
3838
- name: Prepare pip wheel
3939
run: |
4040
which python
@@ -73,7 +73,7 @@ jobs:
7373
strategy:
7474
fail-fast: false
7575
matrix:
76-
python-version: ['3.8', '3.9', '3.10', '3.11']
76+
python-version: ['3.9', '3.10', '3.11', '3.12']
7777
timeout-minutes: 40
7878
steps:
7979
- uses: actions/checkout@v4
@@ -118,14 +118,14 @@ jobs:
118118
strategy:
119119
fail-fast: false
120120
matrix:
121-
pytorch-version: ['1.9.1', '1.10.2', '1.11.0', '1.12.1', '1.13', 'latest']
121+
pytorch-version: ['1.10.2', '1.11.0', '1.12.1', '1.13', '2.0.1', 'latest']
122122
timeout-minutes: 40
123123
steps:
124124
- uses: actions/checkout@v4
125-
- name: Set up Python 3.8
125+
- name: Set up Python 3.9
126126
uses: actions/setup-python@v5
127127
with:
128-
python-version: '3.8'
128+
python-version: '3.9'
129129
- name: Prepare pip wheel
130130
run: |
131131
which python

.github/workflows/setupapp.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ jobs:
7777
runs-on: ubuntu-latest
7878
strategy:
7979
matrix:
80-
python-version: ['3.8', '3.9', '3.10']
80+
python-version: ['3.9', '3.10', '3.11']
8181
steps:
8282
- uses: actions/checkout@v4
8383
with:
@@ -119,10 +119,10 @@ jobs:
119119
install: # pip install from github url, the default branch is dev
120120
runs-on: ubuntu-latest
121121
steps:
122-
- name: Set up Python 3.8
122+
- name: Set up Python 3.9
123123
uses: actions/setup-python@v5
124124
with:
125-
python-version: '3.8'
125+
python-version: '3.9'
126126
- name: cache weekly timestamp
127127
id: pip-cache
128128
run: |

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ or (for new features that would not break existing functionality):
123123
```
124124

125125
It is recommended that the new test `test_[module_name].py` is constructed by using only
126-
python 3.8+ build-in functions, `torch`, `numpy`, `coverage` (for reporting code coverages) and `parameterized` (for organising test cases) packages.
126+
python 3.9+ build-in functions, `torch`, `numpy`, `coverage` (for reporting code coverages) and `parameterized` (for organising test cases) packages.
127127
If it requires any other external packages, please make sure:
128128
- the packages are listed in [`requirements-dev.txt`](requirements-dev.txt)
129129
- the new test `test_[module_name].py` is added to the `exclude_cases` in [`./tests/min_tests.py`](./tests/min_tests.py) so that

docs/images/python.svg

Lines changed: 1 addition & 1 deletion
Loading

docs/source/installation.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
---
2121

22-
MONAI's core functionality is written in Python 3 (>= 3.8) and only requires [Numpy](https://numpy.org/) and [Pytorch](https://pytorch.org/).
22+
MONAI's core functionality is written in Python 3 (>= 3.9) and only requires [Numpy](https://numpy.org/) and [Pytorch](https://pytorch.org/).
2323

2424
The package is currently distributed via Github as the primary source code repository,
2525
and the Python package index (PyPI). The pre-built Docker images are made available on DockerHub.

monai/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
from ._version import get_versions
1818

1919
PY_REQUIRED_MAJOR = 3
20-
PY_REQUIRED_MINOR = 8
20+
PY_REQUIRED_MINOR = 9
2121

2222
version_dict = get_versions()
2323
__version__: str = version_dict.get("version", "0+unknown")

monai/apps/auto3dseg/auto_runner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -551,7 +551,7 @@ def set_device_info(
551551
cmd_prefix: command line prefix for subprocess running in BundleAlgo and EnsembleRunner.
552552
Default using env "CMD_PREFIX" or None, examples are:
553553
554-
- single GPU/CPU or multinode bcprun: "python " or "/opt/conda/bin/python3.8 ",
554+
- single GPU/CPU or multinode bcprun: "python " or "/opt/conda/bin/python3.9 ",
555555
- single node multi-GPU running "torchrun --nnodes=1 --nproc_per_node=2 "
556556
557557
If user define this prefix, please make sure --nproc_per_node matches cuda_visible_device or

monai/auto3dseg/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ def _prepare_cmd_default(cmd: str, cmd_prefix: str | None = None, **kwargs: Any)
407407
408408
Args:
409409
cmd: the command or script to run in the distributed job.
410-
cmd_prefix: the command prefix to run the script, e.g., "python", "python -m", "python3", "/opt/conda/bin/python3.8 ".
410+
cmd_prefix: the command prefix to run the script, e.g., "python", "python -m", "python3", "/opt/conda/bin/python3.9 ".
411411
kwargs: the keyword arguments to be passed to the script.
412412
413413
Returns:

setup.cfg

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ classifiers =
2121
Intended Audience :: Healthcare Industry
2222
Programming Language :: C++
2323
Programming Language :: Python :: 3
24-
Programming Language :: Python :: 3.8
2524
Programming Language :: Python :: 3.9
2625
Programming Language :: Python :: 3.10
26+
Programming Language :: Python :: 3.11
2727
Topic :: Scientific/Engineering
2828
Topic :: Scientific/Engineering :: Artificial Intelligence
2929
Topic :: Scientific/Engineering :: Medical Science Apps.
@@ -33,7 +33,7 @@ classifiers =
3333
Typing :: Typed
3434

3535
[options]
36-
python_requires = >= 3.8
36+
python_requires = >= 3.9
3737
# for compiling and develop setup only
3838
# no need to specify the versions so that we could
3939
# compile for multiple targeted versions.

0 commit comments

Comments
 (0)