Skip to content

Updated the metadata for all models, focused on name, description, and task for Model Zoo website improvements. #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 30, 2025

Conversation

zephyrie
Copy link
Collaborator

@zephyrie zephyrie commented Jun 9, 2025

Description

Updated the metadata for all models, focused on name, description, and task for Model Zoo website improvements.

Status

Ready/Work in progress/Hold

Please ensure all the checkboxes:

  • [] Codeformat tests passed locally by running ./runtests.sh --codeformat.
  • In-line docstrings updated.
  • Update version and changelog in metadata.json if changing an existing bundle.
  • Please ensure the naming rules in config files meet our requirements (please refer to: CONTRIBUTING.md).
  • Ensure versions of packages such as monai, pytorch and numpy are correct in metadata.json.
  • Descriptions should be consistent with the content, such as eval_metrics of the provided weights and TorchScript modules.
  • Files larger than 25MB are excluded and replaced by providing download links in large_file.yml.
  • Avoid using path that contains personal information within config files (such as use /home/your_name/ for "bundle_root").

@zephyrie zephyrie requested a review from yiheng-wang-nv June 9, 2025 23:41
@zephyrie
Copy link
Collaborator Author

zephyrie commented Jun 9, 2025

@yiheng-wang-nv, there were some issues with ./runtests.sh --codeformat, but they were in code I didn't touch so I left them alone for now. Everything else looked fine.

@zephyrie zephyrie force-pushed the update_metadata_all_models branch from e538a1e to 4dfd556 Compare June 17, 2025 02:42
@zephyrie
Copy link
Collaborator Author

@ericspod, I found 7 instances of the 'authors' key issue that I've fixed now.

Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@yiheng-wang-nv
Copy link
Collaborator

/build

Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
Copy link
Collaborator

/build

Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv
Copy link
Collaborator

/build

@yiheng-wang-nv
Copy link
Collaborator

The current cpu check error is due to github's machine does not have enough spaces (this PR changes multiple bundles, thus requires large spaces). Since the blossom machine based tests are successful, I will temporarily modify the PR merge requirement, and merge it first. cc @ericspod

@yiheng-wang-nv yiheng-wang-nv merged commit 55fc1da into Project-MONAI:dev Jun 30, 2025
3 of 4 checks passed
@ericspod
Copy link
Member

The current cpu check error is due to github's machine does not have enough spaces (this PR changes multiple bundles, thus requires large spaces). Since the blossom machine based tests are successful, I will temporarily modify the PR merge requirement, and merge it first. cc @ericspod

This was the only way forward at the moment so it's fine. I would suggest we need to consider here, and in other repos, how to formulate test rules to be skipped if documentation files alone are changed in which case code doesn't need testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants