-
Notifications
You must be signed in to change notification settings - Fork 81
Updated the metadata for all models, focused on name, description, and task for Model Zoo website improvements. #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the metadata for all models, focused on name, description, and task for Model Zoo website improvements. #752
Conversation
…d task for Model Zoo website improvements.
@yiheng-wang-nv, there were some issues with |
e538a1e
to
4dfd556
Compare
for more information, see https://pre-commit.ci
@ericspod, I found 7 instances of the 'authors' key issue that I've fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
/build |
Signed-off-by: Yiheng Wang <[email protected]>
/build |
Signed-off-by: Yiheng Wang <[email protected]>
/build |
The current cpu check error is due to github's machine does not have enough spaces (this PR changes multiple bundles, thus requires large spaces). Since the blossom machine based tests are successful, I will temporarily modify the PR merge requirement, and merge it first. cc @ericspod |
This was the only way forward at the moment so it's fine. I would suggest we need to consider here, and in other repos, how to formulate test rules to be skipped if documentation files alone are changed in which case code doesn't need testing. |
Description
Updated the metadata for all models, focused on name, description, and task for Model Zoo website improvements.
Status
Ready/Work in progress/Hold
Please ensure all the checkboxes:
./runtests.sh --codeformat
.version
andchangelog
inmetadata.json
if changing an existing bundle.CONTRIBUTING.md
).monai
,pytorch
andnumpy
are correct inmetadata.json
.eval_metrics
of the provided weights and TorchScript modules.large_file.yml
./home/your_name/
for"bundle_root"
).