x.c:widget_values_get(): use a reference into a XtArgVal array.

x.c:args_to_pairs(): When going from X -> ML, X seems to want a valid pointer,
so dereference even though its supposedly "unboxed".

Author: ratmice

src/rts/src/OS/Unix/x.c

@@ -1180,7 +1180,7 @@ static void args_to_pairs(Arg args[], mlval list)
       break;
 
     case mlw_x_arg_unboxed:
-      mlw_ref_update(ref, (mlval)args[nr_args].value);
+      mlw_ref_update(ref, (mlval)*(XtArgVal*)args[nr_args].value);
       break;
 
     default:
@@ -1885,23 +1885,15 @@ static mlval widget_values_set(mlval argument)
 static mlval widget_values_get(mlval argument)
 {
   Arg args[MAX_NR_ARGS];
+  XtArgVal vals[MAX_NR_ARGS];
   Cardinal nr_args, i;
   mlval list = FIELD(argument, 1);
 
   pairs_to_args(args, &nr_args, list);
   for(i=0; i<nr_args; ++i) {
-    XtArgVal tmp = (XtArgVal)XtMalloc(sizeof (XtArgVal));
-    if (tmp == 0)
-      error("widget_values_get: malloc failed", 0, 0);
-    else
-      args[i].value = tmp;
+      args[i].value = (XtArgVal)&vals[i];
   }
   XtGetValues((Widget)FIELD(argument, 0), args, nr_args);
-  for(i=0; i<nr_args; ++i) {
-    XtArgVal *tmp = (XtArgVal*)args[i].value;
-    args[i].value = *tmp;
-    XtFree ((char*)tmp);
-  }
   args_to_pairs(args, list);
 
   return(MLUNIT);