Change in Unary operator

Author: Aggarwal-Raghav

go_lexer.py

@@ -28,7 +28,7 @@ def find_column(token):
 states = (("InsertSemi", "exclusive"),)
 
 # List of literal tokens
-literals = ";,.=+-*/%()[]{}"
+literals = ";,.=+-*/%()[]!{}"
 
 # List of token names. This is always required
 tokens = (
@@ -45,7 +45,7 @@ def find_column(token):
     "BAR",
     "AMPER_AMPER",
     "BAR_BAR",
-    "EXCLAMATION",
+    #  "EXCLAMATION",
     "COLON",
     # assignment operators
     "WALRUS",
@@ -197,7 +197,7 @@ def t_ANY_ignore_MULTI_COMMENT(t):
 t_BAR = r"\|"
 t_AMPER_AMPER = r"&&"
 t_BAR_BAR = r"\|\|"
-t_EXCLAMATION = r"!"
+#  t_EXCLAMATION = r"!"
 t_COLON = r":"
 t_WALRUS = r":="
 # TODO: Move the assignment operators above, below

go_parser.py

@@ -617,6 +617,7 @@ def p_UnaryExpr(p):
 def p_UnaryOp(p):
     """UnaryOp : '+' %prec UNARY
     | '-' %prec UNARY
+    | '!' %prec UNARY
     """
     # TODO : Add other unary operators
     p[0] = p[1]

syntree.py

@@ -44,6 +44,7 @@ class BinOp(Node):
     """Node for binary operations"""
 
     rel_ops = {"==", "!=", "<", ">", "<=", ">="}
+    logical_ops = {"&&", "||"}
 
     def __init__(self, operator, left=None, right=None, lineno=None):
         super().__init__("Binary", children=[left, right], data=operator)
@@ -53,6 +54,7 @@ def __init__(self, operator, left=None, right=None, lineno=None):
         self.lineno = lineno
 
         self.is_relop = self.operator in self.rel_ops
+        self.is_logical = self.operator in self.logical_ops
 
         self.type_ = None
         try:
@@ -75,10 +77,6 @@ def get_type(child: Node) -> str:
 
                 return x
 
-            Logical_Oper = ["&&", "||"]
-            if self.data in Logical_Oper:
-                self.type = "bool"
-
             x = get_type(self.children[0])
             y = get_type(self.children[1])
 
@@ -105,11 +103,17 @@ def check_type(x, y):
                     print_line_marker_nowhitespace(self.lineno)
 
                 if self.is_relop:
-                    self.type = "bool"
+                    self.type_ = "bool"
 
             else:
                 if self.is_relop:
-                    self.type = "bool"
+                    self.type_ = "bool"
+
+                elif self.is_logical:
+                    if x == "bool":
+                        self.type_ = "bool"
+                    else:
+                        print_error("Invalid Operation", kind="Operation Error")
 
                 else:
                     self.type_ = x
@@ -138,6 +142,12 @@ def __init__(self, operator, operand):
         else:
             self.type_ = operand.data[0]
 
+        if self.type_ == "string":
+            print_error("Type Error", kind="Invalid Operation")
+
+        if self.operator == '!' and self.type_ != "bool":
+            print_error("Type Error", kind="Invalid Operation")
+
 
 class PrimaryExpr(Node):
     """Node for PrimaryExpr
@@ -560,9 +570,7 @@ def __init__(self, body, expr, statement=None, next_=None, lineno=None):
         self._no_optim = True
 
         if isinstance(self.expr, BinOp):
-            if self.expr.data in ["&&", "||"]:
-                pass
-            elif not self.expr.is_relop:
+            if self.expr.type_ != "bool":
                 print_error("Invalid operator in condition", kind="ERROR")
                 print("Cannot use non-boolean binary operator "
                       f"{self.expr.operator}"

tests/logical_oper.go

@@ -4,6 +4,10 @@ func main() {
     var p int = 23
     var q int = 60
 
+    // if(1 && 8){
+    //     fmt.Println("True")
+    // }
+
     if(p!=q && p<=q){
         fmt.Println("True")
     }
@@ -12,8 +16,9 @@ func main() {
         fmt.Println("True")
     }
 
-    // if(!(p==q)){
-    //     fmt.Println("True")
-    // }
+    if(!(p==q)){
+        fmt.Println("True")
+    }
+    // const abc = !(true)
 
 }