Skip to content

Commit 6eb725d

Browse files
authored
Checks if success term exists before recording in RecorderManager (isaac-sim#2218)
# Description <!-- Thank you for your interest in sending a pull request. Please make sure to check the contribution guidelines. Link: https://isaac-sim.github.io/IsaacLab/main/source/refs/contributing.html --> Adds a check in RecorderManager to only record success results if success termination term exists. Fixes isaac-sim#2190 Fixes recorder crash if added to ManagerBasedEnv. ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task -->
1 parent ce5c666 commit 6eb725d

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

source/isaaclab/config/extension.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[package]
22

33
# Note: Semantic Versioning is used: https://semver.org/
4-
version = "0.36.3"
4+
version = "0.36.5"
55

66
# Description
77
title = "Isaac Lab framework for Robot Learning"

source/isaaclab/docs/CHANGELOG.rst

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,15 @@
11
Changelog
22
---------
33

4+
0.36.5 (2025-04-01)
5+
~~~~~~~~~~~~~~~~~~~
6+
7+
Fixed
8+
^^^^^
9+
10+
* Adds check in RecorderManager to ensure that the success indicator is only set if the termination manager is present.
11+
12+
413
0.36.4 (2025-03-24)
514
~~~~~~~~~~~~~~~~~~~
615

source/isaaclab/isaaclab/managers/recorder_manager.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -385,8 +385,9 @@ def record_pre_reset(self, env_ids: Sequence[int] | None, force_export_or_skip=N
385385
# Set task success values for the relevant episodes
386386
success_results = torch.zeros(len(env_ids), dtype=bool, device=self._env.device)
387387
# Check success indicator from termination terms
388-
if "success" in self._env.termination_manager.active_terms:
389-
success_results |= self._env.termination_manager.get_term("success")[env_ids]
388+
if hasattr(self._env, "termination_manager"):
389+
if "success" in self._env.termination_manager.active_terms:
390+
success_results |= self._env.termination_manager.get_term("success")[env_ids]
390391
self.set_success_to_episodes(env_ids, success_results)
391392

392393
if force_export_or_skip or (force_export_or_skip is None and self.cfg.export_in_record_pre_reset):

0 commit comments

Comments
 (0)