Skip to content

Commit 4307bf1

Browse files
Merge pull request #2717 from SciML/os/fix-tests
fix even more ci?
2 parents eba1ff5 + a1a513c commit 4307bf1

File tree

6 files changed

+2
-64
lines changed

6 files changed

+2
-64
lines changed

.buildkite/pipeline.yml

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,6 @@ steps:
33
plugins:
44
- JuliaCI/julia#v1:
55
version: "1"
6-
- staticfloat/metahook:
7-
pre-command: |
8-
julia --project=. -e '
9-
using Pkg;
10-
VERSION < v"1.11" && Pkg.develop(map(path ->Pkg.PackageSpec.(;path="$(@__DIR__)/lib/$(path)"), readdir("./lib")));
11-
Pkg.instantiate();
12-
'
136
- JuliaCI/julia-test#v1:
147
coverage: false # 1000x slowdown
158
agents:
@@ -41,13 +34,6 @@ steps:
4134
JULIA_NUM_THREADS: 2
4235
plugins:
4336
- JuliaCI/julia#v1
44-
- staticfloat/metahook:
45-
pre-command: |
46-
julia --project=. -e '
47-
using Pkg;
48-
VERSION < v"1.11" && Pkg.develop(map(path ->Pkg.PackageSpec.(;path="$(@__DIR__)/lib/$(path)"), readdir("./lib")));
49-
Pkg.instantiate();
50-
'
5137
- JuliaCI/julia-test#v1:
5238
coverage: false
5339
agents:

.github/workflows/CI.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,6 @@ jobs:
7878
${{ runner.os }}-test-${{ env.cache-name }}-
7979
${{ runner.os }}-test-
8080
${{ runner.os }}-
81-
# Explicitly develop the libraries first before running the tests for now.
82-
# This is necessary since the tests are likely to fail otherwise, given that all
83-
# the libs haven't been registered yet.
84-
- name: "Develop the libraries since they haven't been registered yet"
85-
run: |
86-
julia --project=. -e '
87-
using Pkg;
88-
VERSION < v"1.11" && Pkg.develop(map(path ->Pkg.PackageSpec.(;path="$(@__DIR__)/lib/$(path)"), readdir("./lib")));
89-
'
9081
- uses: julia-actions/julia-runtest@v1
9182
with:
9283
coverage: false

.github/workflows/Documentation.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,6 @@ jobs:
1515
- uses: julia-actions/setup-julia@latest
1616
with:
1717
version: '1'
18-
# Explicitly develop the libraries first before running the tests for now.
19-
# This is necessary since the tests are likely to fail otherwise, given that all
20-
# the libs haven't been registered yet.
21-
- name: "Develop the libraries since they haven't been registered yet"
22-
run: |
23-
julia --project=. -e '
24-
using Pkg;
25-
Pkg.develop(map(path ->Pkg.PackageSpec.(;path="$(@__DIR__)/lib/$(path)"), readdir("./lib")));
26-
'
2718
- name: Install dependencies
2819
run: julia --project=docs/ -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate()'
2920
- name: Build and deploy

.github/workflows/Downstream.yml

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -44,32 +44,11 @@ jobs:
4444
with:
4545
version: ${{ matrix.julia-version }}
4646
arch: x64
47-
# Explicitly develop the libraries first before running the tests for now.
48-
# This is necessary since the tests are likely to fail otherwise, given that all
49-
# the libs haven't been registered yet.
5047
- name: Clone Downstream
5148
uses: actions/checkout@v4
5249
with:
5350
repository: ${{ matrix.package.user }}/${{ matrix.package.repo }}
5451
path: downstream
55-
- name: Load this and run the downstream tests
56-
shell: julia --color=yes --project=downstream {0}
57-
run: |
58-
using Pkg
59-
try
60-
# force it to use this PR's version of the package
61-
VERSION < v"1.11" && Pkg.develop(map(path ->Pkg.PackageSpec.(;path="lib/$(path)"), readdir("./lib")));
62-
VERSION < v"1.11" && Pkg.develop(PackageSpec(path=".")) # resolver may fail with main deps
63-
Pkg.update()
64-
Pkg.test(coverage=true) # resolver may fail with test time deps
65-
catch err
66-
err isa Pkg.Resolve.ResolverError || rethrow()
67-
# If we can't resolve that means this is incompatible by SemVer and this is fine
68-
# It means we marked this as a breaking change, so we don't need to worry about
69-
# mistakenly introducing a breaking change, as we have intentionally made one
70-
@info "Not compatible with this release. No problem." exception=err
71-
exit(0) # Exit immediately, as a success
72-
end
7352
- uses: julia-actions/julia-processcoverage@v1
7453
- uses: codecov/codecov-action@v5
7554
with:

.github/workflows/Invalidations.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,6 @@ jobs:
2020
with:
2121
version: '1'
2222
- uses: actions/checkout@v4
23-
# Explicitly develop the libraries first before running the tests for now.
24-
# This is necessary since the tests are likely to fail otherwise, given that all
25-
# the libs haven't been registered yet.
26-
- name: "Develop the libraries since they haven't been registered yet"
27-
run: |
28-
julia --project=. -e '
29-
using Pkg;
30-
VERSION < v"1.11" && Pkg.develop(map(path ->Pkg.PackageSpec.(;path="$(@__DIR__)/lib/$(path)"), readdir("./lib")));
31-
'
3223
- uses: julia-actions/julia-invalidations@v1
3324
id: invs_pr
3425

test/runtests.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ end
3333

3434
@time begin
3535
if contains(GROUP, "OrdinaryDiffEq") || GROUP == "ImplicitDiscreteSolve" || GROUP == "SimpleImplicitDiscreteSolve"
36-
Pkg.develop(path = "../lib/$GROUP")
37-
Pkg.test(GROUP)
36+
Pkg.activate(joinpath(dirname(@__DIR__), "lib", GROUP))
37+
Pkg.test(GROUP, julia_args=["--check-bounds=auto", "--compiled-modules=yes", "--depwarn=yes"], force_latest_compatible_version=false, allow_reresolve=true)
3838
elseif GROUP == "All" || GROUP == "InterfaceI" || GROUP == "Interface"
3939
@time @safetestset "Discrete Algorithm Tests" include("interface/discrete_algorithm_test.jl")
4040
@time @safetestset "Tstops Tests" include("interface/ode_tstops_tests.jl")

0 commit comments

Comments
 (0)