Sidhant29
diff --git a/‎.github/workflows/ci.yml
Lines changed: 1 addition & 1 deletion b/‎.github/workflows/ci.yml
Lines changed: 1 addition & 1 deletion
diff --git a/‎Cargo.lock
Lines changed: 23 additions & 22 deletions b/‎Cargo.lock
Lines changed: 23 additions & 22 deletions
diff --git a/‎Cargo.toml
Lines changed: 2 additions & 2 deletions b/‎Cargo.toml
Lines changed: 2 additions & 2 deletions
diff --git a/‎Makefile
Lines changed: 5 additions & 2 deletions b/‎Makefile
Lines changed: 5 additions & 2 deletions
diff --git a/‎rustfmt.toml
Lines changed: 1 addition & 1 deletion b/‎rustfmt.toml
Lines changed: 1 addition & 1 deletion
diff --git a/‎src/document.rs
Lines changed: 29 additions & 26 deletions b/‎src/document.rs
Lines changed: 29 additions & 26 deletions
diff --git a/‎src/index.rs
Lines changed: 24 additions & 28 deletions b/‎src/index.rs
Lines changed: 24 additions & 28 deletions
diff --git a/‎src/lib.rs
Lines changed: 2 additions & 3 deletions b/‎src/lib.rs
Lines changed: 2 additions & 3 deletions
@@ -31,7 +31,7 @@ jobs:
           components: rustfmt
 
       - name: Check Formatting
-        run: rustfmt --check src/*.rs
+        run: cargo fmt --check
 
   Test:
     strategy:
 
@@ -1,6 +1,6 @@
 [package]
 name = "tantivy"
-version = "0.19.1"
+version = "0.19.2"
 readme = "README.md"
 authors = ["Damir Jelić <[email protected]>"]
 edition = "2018"
@@ -22,4 +22,4 @@ serde_json = { version = "1.0.93" }
 
 [dependencies.pyo3]
 version = "0.18.0"
-features = ["extension-module"]
+features = ["extension-module"]
@@ -6,15 +6,18 @@ endif
 
 source_files := $(wildcard src/*.rs)
 
-all: build
+all: format lint build test
 
 PHONY: test format
 
+lint:
+	cargo clippy
+
 test: tantivy/tantivy.$(EXT)
 	python3 -m pytest
 
 format:
-	rustfmt src/*.rs
+	cargo fmt
 
 build:
 	maturin build --interpreter python3.7 python3.8 python3.9 python3.10 python3.11
 
@@ -1 +1 @@
-max_width = 80
+max_width = 80
@@ -56,23 +56,26 @@ fn value_to_py(py: Python, value: &Value) -> PyResult<PyObject> {
             // TODO implement me
             unimplemented!();
         }
-        Value::Date(d) => PyDateTime::new(
-            py,
-            d.into_utc().year(),
-            d.into_utc().month() as u8,
-            d.into_utc().day() as u8,
-            d.into_utc().hour() as u8,
-            d.into_utc().minute() as u8,
-            d.into_utc().second() as u8,
-            d.into_utc().microsecond() as u32,
-            None,
-        )?
-        .into_py(py),
+        Value::Date(d) => {
+            let utc = d.into_utc();
+            PyDateTime::new(
+                py,
+                utc.year(),
+                utc.month() as u8,
+                utc.day(),
+                utc.hour(),
+                utc.minute(),
+                utc.second(),
+                utc.microsecond(),
+                None,
+            )?
+            .into_py(py)
+        }
         Value::Facet(f) => Facet { inner: f.clone() }.into_py(py),
         Value::JsonObject(json_object) => {
             let inner: HashMap<_, _> = json_object
                 .iter()
-                .map(|(k, v)| (k, value_to_object(&v, py)))
+                .map(|(k, v)| (k, value_to_object(v, py)))
                 .collect();
             inner.to_object(py)
         }
@@ -84,11 +87,11 @@ fn value_to_py(py: Python, value: &Value) -> PyResult<PyObject> {
 fn value_to_string(value: &Value) -> String {
     match value {
         Value::Str(text) => text.clone(),
-        Value::U64(num) => format!("{}", num),
-        Value::I64(num) => format!("{}", num),
-        Value::F64(num) => format!("{}", num),
-        Value::Bytes(bytes) => format!("{:?}", bytes),
-        Value::Date(d) => format!("{:?}", d),
+        Value::U64(num) => format!("{num}"),
+        Value::I64(num) => format!("{num}"),
+        Value::F64(num) => format!("{num}"),
+        Value::Bytes(bytes) => format!("{bytes:?}"),
+        Value::Date(d) => format!("{d:?}"),
         Value::Facet(facet) => facet.to_string(),
         Value::PreTokStr(_pretok) => {
             // TODO implement me
@@ -97,7 +100,7 @@ fn value_to_string(value: &Value) -> String {
         Value::JsonObject(json_object) => {
             serde_json::to_string(&json_object).unwrap()
         }
-        Value::Bool(b) => format!("{}", b),
+        Value::Bool(b) => format!("{b}"),
         Value::IpAddr(i) => format!("{}", *i),
     }
 }
@@ -145,10 +148,10 @@ impl fmt::Debug for Document {
                     .chars()
                     .take(10)
                     .collect();
-                format!("{}=[{}]", field_name, values_str)
+                format!("{field_name}=[{values_str}]")
             })
             .join(",");
-        write!(f, "Document({})", doc_str)
+        write!(f, "Document({doc_str})")
     }
 }
 
@@ -189,9 +192,9 @@ pub(crate) fn extract_value(any: &PyAny) -> PyResult<Value> {
         )));
     }
     if let Ok(facet) = any.extract::<Facet>() {
-        return Ok(Value::Facet(facet.inner.clone()));
+        return Ok(Value::Facet(facet.inner));
     }
-    Err(to_pyerr(format!("Value unsupported {:?}", any)))
+    Err(to_pyerr(format!("Value unsupported {any:?}")))
 }
 
 fn extract_value_single_or_list(any: &PyAny) -> PyResult<Vec<Value>> {
@@ -404,13 +407,13 @@ impl Document {
     }
 
     fn __getitem__(&self, field_name: &str) -> PyResult<Vec<PyObject>> {
-        return Python::with_gil(|py| -> PyResult<Vec<PyObject>> {
+        Python::with_gil(|py| -> PyResult<Vec<PyObject>> {
             self.get_all(py, field_name)
-        });
+        })
     }
 
     fn __repr__(&self) -> PyResult<String> {
-        Ok(format!("{:?}", self))
+        Ok(format!("{self:?}"))
     }
 }
 
 
@@ -133,20 +133,17 @@ impl IndexWriter {
             Value::Facet(facet) => Term::from_facet(field, &facet),
             Value::Bytes(_) => {
                 return Err(exceptions::PyValueError::new_err(format!(
-                    "Field `{}` is bytes type not deletable.",
-                    field_name
+                    "Field `{field_name}` is bytes type not deletable."
                 )))
             }
             Value::PreTokStr(_pretok) => {
                 return Err(exceptions::PyValueError::new_err(format!(
-                    "Field `{}` is pretokenized. This is not authorized for delete.",
-                    field_name
+                    "Field `{field_name}` is pretokenized. This is not authorized for delete."
                 )))
             }
             Value::JsonObject(_) => {
                 return Err(exceptions::PyValueError::new_err(format!(
-                    "Field `{}` is json object type not deletable.",
-                    field_name
+                    "Field `{field_name}` is json object type not deletable."
                 )))
             },
             Value::Bool(b) => Term::from_field_bool(field, b),
@@ -365,16 +362,14 @@ impl Index {
                     if !field_entry.is_indexed() {
                         return Err(exceptions::PyValueError::new_err(
                             format!(
-                            "Field `{}` is not set as indexed in the schema.",
-                            default_field_name
+                            "Field `{default_field_name}` is not set as indexed in the schema."
                         ),
                         ));
                     }
                     default_fields.push(field);
                 } else {
                     return Err(exceptions::PyValueError::new_err(format!(
-                        "Field `{}` is not defined in the schema.",
-                        default_field_name
+                        "Field `{default_field_name}` is not defined in the schema."
                     )));
                 }
             }
@@ -395,24 +390,25 @@ impl Index {
 
 impl Index {
     fn register_custom_text_analyzers(index: &tv::Index) {
-        let mut analyzers = HashMap::new();
-        analyzers.insert("ar_stem", Language::Arabic);
-        analyzers.insert("da_stem", Language::Danish);
-        analyzers.insert("nl_stem", Language::Dutch);
-        analyzers.insert("fi_stem", Language::Finnish);
-        analyzers.insert("fr_stem", Language::French);
-        analyzers.insert("de_stem", Language::German);
-        analyzers.insert("el_stem", Language::Greek);
-        analyzers.insert("hu_stem", Language::Hungarian);
-        analyzers.insert("it_stem", Language::Italian);
-        analyzers.insert("no_stem", Language::Norwegian);
-        analyzers.insert("pt_stem", Language::Portuguese);
-        analyzers.insert("ro_stem", Language::Romanian);
-        analyzers.insert("ru_stem", Language::Russian);
-        analyzers.insert("es_stem", Language::Spanish);
-        analyzers.insert("sv_stem", Language::Swedish);
-        analyzers.insert("ta_stem", Language::Tamil);
-        analyzers.insert("tr_stem", Language::Turkish);
+        let analyzers = [
+            ("ar_stem", Language::Arabic),
+            ("da_stem", Language::Danish),
+            ("nl_stem", Language::Dutch),
+            ("fi_stem", Language::Finnish),
+            ("fr_stem", Language::French),
+            ("de_stem", Language::German),
+            ("el_stem", Language::Greek),
+            ("hu_stem", Language::Hungarian),
+            ("it_stem", Language::Italian),
+            ("no_stem", Language::Norwegian),
+            ("pt_stem", Language::Portuguese),
+            ("ro_stem", Language::Romanian),
+            ("ru_stem", Language::Russian),
+            ("es_stem", Language::Spanish),
+            ("sv_stem", Language::Swedish),
+            ("ta_stem", Language::Tamil),
+            ("tr_stem", Language::Turkish),
+        ];
 
         for (name, lang) in &analyzers {
             let an = TextAnalyzer::from(SimpleTokenizer)
 
@@ -1,6 +1,6 @@
-use pyo3::{exceptions, prelude::*};
 #[rustfmt::skip]
 use ::tantivy as tv;
+use pyo3::{exceptions, prelude::*};
 
 mod document;
 mod facet;
@@ -90,8 +90,7 @@ pub(crate) fn get_field(
 ) -> PyResult<tv::schema::Field> {
     let field = schema.get_field(field_name).ok_or_else(|| {
         exceptions::PyValueError::new_err(format!(
-            "Field `{}` is not defined in the schema.",
-            field_name
+            "Field `{field_name}` is not defined in the schema."
         ))
     })?;