Skip to content

Commit 71cadd5

Browse files
ahmadshaheershivanshuraj1333
authored andcommitted
chore: remove dev env check
1 parent f9cebe2 commit 71cadd5

File tree

3 files changed

+33
-40
lines changed

3 files changed

+33
-40
lines changed

frontend/src/container/TraceWaterfall/TraceWaterfallStates/Success/Success.tsx

Lines changed: 23 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -149,30 +149,28 @@ function SpanOverview({
149149
<Typography.Text className="service-name">
150150
{span.serviceName}
151151
</Typography.Text>
152-
{!!span.serviceName &&
153-
!!span.name &&
154-
process.env.NODE_ENV === 'development' && (
155-
<div className="add-funnel-button">
156-
<span className="add-funnel-button__separator">·</span>
157-
<Button
158-
type="text"
159-
size="small"
160-
className="add-funnel-button__button"
161-
onClick={(e): void => {
162-
e.preventDefault();
163-
e.stopPropagation();
164-
handleAddSpanToFunnel(span);
165-
}}
166-
icon={
167-
<img
168-
className="add-funnel-button__icon"
169-
src="/Icons/funnel-add.svg"
170-
alt="funnel-icon"
171-
/>
172-
}
173-
/>
174-
</div>
175-
)}
152+
{!!span.serviceName && !!span.name && (
153+
<div className="add-funnel-button">
154+
<span className="add-funnel-button__separator">·</span>
155+
<Button
156+
type="text"
157+
size="small"
158+
className="add-funnel-button__button"
159+
onClick={(e): void => {
160+
e.preventDefault();
161+
e.stopPropagation();
162+
handleAddSpanToFunnel(span);
163+
}}
164+
icon={
165+
<img
166+
className="add-funnel-button__icon"
167+
src="/Icons/funnel-add.svg"
168+
alt="funnel-icon"
169+
/>
170+
}
171+
/>
172+
</div>
173+
)}
176174
</section>
177175
</div>
178176
</div>
@@ -475,7 +473,7 @@ function Success(props: ISuccessProps): JSX.Element {
475473
virtualiserRef={virtualizerRef}
476474
setColumnWidths={setTraceFlamegraphStatsWidth}
477475
/>
478-
{selectedSpanToAddToFunnel && process.env.NODE_ENV === 'development' && (
476+
{selectedSpanToAddToFunnel && (
479477
<AddSpanToFunnelModal
480478
span={selectedSpanToAddToFunnel}
481479
isOpen={isAddSpanToFunnelModalOpen}

frontend/src/pages/TraceDetailV2/index.tsx

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -67,19 +67,15 @@ export default function TraceDetailsPage(): JSX.Element {
6767
key: 'trace-details',
6868
children: <TraceDetailsV2 />,
6969
},
70-
...(process.env.NODE_ENV === 'development'
71-
? [
72-
{
73-
label: (
74-
<div className="tab-item">
75-
<Cone className="funnel-icon" size={16} /> Funnels
76-
</div>
77-
),
78-
key: 'funnels',
79-
children: <div />,
80-
},
81-
]
82-
: []),
70+
{
71+
label: (
72+
<div className="tab-item">
73+
<Cone className="funnel-icon" size={16} /> Funnels
74+
</div>
75+
),
76+
key: 'funnels',
77+
children: <div />,
78+
},
8379
{
8480
label: (
8581
<div className="tab-item">

frontend/src/pages/TracesModulePage/TracesModulePage.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,7 @@ function TracesModulePage(): JSX.Element {
1414

1515
const routes: TabRoutes[] = [
1616
tracesExplorer,
17-
// TODO(shaheer): remove this check after everything is ready
18-
process.env.NODE_ENV === 'development' ? tracesFunnel(pathname) : null,
17+
tracesFunnel(pathname),
1918
tracesSaveView,
2019
].filter(Boolean) as TabRoutes[];
2120

0 commit comments

Comments
 (0)