Skip to content

Commit f7b973d

Browse files
committed
fix: hide funnel title and description from add span to funnel modal and fix the modal height
1 parent deda49f commit f7b973d

File tree

2 files changed

+19
-10
lines changed

2 files changed

+19
-10
lines changed

frontend/src/pages/TracesFunnelDetails/components/FunnelConfiguration/FunnelConfiguration.styles.scss

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,13 @@
33
display: flex;
44
flex-direction: column;
55
justify-content: space-between;
6-
height: calc(
7-
100vh - 170px
8-
); // 64px bottom bar + 61px configuration header + 45px page navbar
9-
overflow: auto;
106
justify-content: flex-start;
7+
&.funnel-details-page {
8+
height: calc(
9+
100vh - 170px
10+
); // 64px bottom bar + 61px configuration header + 45px page navbar
11+
overflow: auto;
12+
}
1113
}
1214

1315
&__header {

frontend/src/pages/TracesFunnelDetails/components/FunnelConfiguration/FunnelConfiguration.tsx

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import './FunnelConfiguration.styles.scss';
22

33
import { Button, Divider, Tooltip } from 'antd';
4+
import cx from 'classnames';
45
import OverlayScrollbar from 'components/OverlayScrollbar/OverlayScrollbar';
56
import useFunnelConfiguration from 'hooks/TracesFunnels/useFunnelConfiguration';
67
import { PencilLine } from 'lucide-react';
@@ -80,15 +81,21 @@ function FunnelConfiguration({
8081
</div>
8182
</div>
8283
)}
83-
<div className="funnel-configuration__steps-wrapper">
84+
<div
85+
className={cx('funnel-configuration__steps-wrapper', {
86+
'funnel-details-page': !isTraceDetailsPage,
87+
})}
88+
>
8489
<OverlayScrollbar>
8590
<>
86-
<div className="funnel-configuration__description-wrapper">
87-
<div className="funnel-title">{funnel.funnel_name}</div>
88-
<div className="funnel-description">
89-
{funnel?.description ?? 'No description added.'}
91+
{!isTraceDetailsPage && (
92+
<div className="funnel-configuration__description-wrapper">
93+
<div className="funnel-title">{funnel.funnel_name}</div>
94+
<div className="funnel-description">
95+
{funnel?.description ?? 'No description added.'}
96+
</div>
9097
</div>
91-
</div>
98+
)}
9299
<div className="funnel-configuration__steps">
93100
{!isTraceDetailsPage && <StepsHeader />}
94101
<StepsContent isTraceDetailsPage={isTraceDetailsPage} span={span} />

0 commit comments

Comments
 (0)