Skip to content
This repository was archived by the owner on Mar 27, 2022. It is now read-only.

Commit 81e6611

Browse files
committed
Fix lupdate bug
1 parent 142b240 commit 81e6611

File tree

3 files changed

+19
-21
lines changed

3 files changed

+19
-21
lines changed

README.md

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -368,19 +368,19 @@ This is the documentation of the qmake feature that is generated by qdep and loa
368368
- `qdep_depends`: Can be added to any variable passed to `SUBDIRS` in a project that uses `QDEP_PROJECT_SUBDIRS` to specify that a certain subdir project depends on that specific package. This does **not** take care of linkage etc. It only ensures that the make targets are build in the correct order.
369369

370370
##### Advanced Variables
371-
Name | Direction | Default | Descriptions
372-
----------------------------|-----------|---------------------------------------|--------------
373-
QDEP_TOOL | in/out | `<system>` | The escaped command line base for qdep commands run from within qmake
374-
QDEP_CACHE_SCOPE | in | `stash` | The method of caching to be used to cache various qmake related stuff. Can be &lt;empty>, super or stash
375-
QDEP_GENERATED_SOURCES_DIR | out | `$$QDEP_GENERATED_DIR/<type>` | The directory where generated source files are placed. Is determined by the build configuration to take debug/release builds into account
376-
QDEP_GENERATED_TS_DIR | in | `$$QDEP_GENERATED_DIR/.qdepts/<type>` | The directory where generated translation sources are placed.
377-
QDEP_LCONVERT | in | `lconvert -sort-contexts` | The path to the lconvert tool and additional arguments to be used to combine translations
378-
QDEP_EXPORT_NAME | in/out | `<pro-file-name>_export.pri` | The name of a generated library import file. Must be only the name of the file, use QDEP_EXPORT_PATH to specify the location
379-
QDEP_EXPORTED_DEFINES | out | `<empty>` | DEFINES that come from QDEP_PACKAGE_EXPORTS or DEFINES from any directly included qdep dependency
380-
QDEP_EXPORTED_INCLUDEPATH | out | `<empty>` | INCLUDEPATHs that come from any directly included qdep dependency
381-
QDEP_EXPORTED_LIBS | out | `<empty>` | LIBS that come from any directly included qdep dependency
382-
QDEP_HOOK_FNS | out | `<empty>` | Holds all names of functions to be run as startup hook by qdep
383-
QDEP_LUPDATE_ARGS | in | `-recursive -locations relative` | Additional arguments for lupdate in the `make lupdate` command to control it's behaviour
371+
Name | Direction | Default | Descriptions
372+
----------------------------|-----------|------------------------------------------|--------------
373+
QDEP_TOOL | in/out | `<system>` | The escaped command line base for qdep commands run from within qmake
374+
QDEP_CACHE_SCOPE | in | `stash` | The method of caching to be used to cache various qmake related stuff. Can be &lt;empty>, super or stash
375+
QDEP_GENERATED_SOURCES_DIR | out | `$$QDEP_GENERATED_DIR/<type>` | The directory where generated source files are placed. Is determined by the build configuration to take debug/release builds into account
376+
QDEP_GENERATED_TS_DIR | in | `$$QDEP_GENERATED_DIR/.qdepts/<type>` | The directory where generated translation sources are placed.
377+
QDEP_LUPDATE | in | `lupdate -recursive -locations relative` | The path to the lupdate tool and additional arguments for lupdate in the `make lupdate` command to control it's behaviour
378+
QDEP_LCONVERT | in | `lconvert -sort-contexts` | The path to the lconvert tool and additional arguments to be used to combine translations
379+
QDEP_EXPORT_NAME | in/out | `<pro-file-name>_export.pri` | The name of a generated library import file. Must be only the name of the file, use QDEP_EXPORT_PATH to specify the location
380+
QDEP_EXPORTED_DEFINES | out | `<empty>` | DEFINES that come from QDEP_PACKAGE_EXPORTS or DEFINES from any directly included qdep dependency
381+
QDEP_EXPORTED_INCLUDEPATH | out | `<empty>` | INCLUDEPATHs that come from any directly included qdep dependency
382+
QDEP_EXPORTED_LIBS | out | `<empty>` | LIBS that come from any directly included qdep dependency
383+
QDEP_HOOK_FNS | out | `<empty>` | Holds all names of functions to be run as startup hook by qdep
384384

385385
#### Configuration values
386386
##### Input value
@@ -416,7 +416,6 @@ This is the documentation of the qmake feature that is generated by qdep and loa
416416
- `__QDEP_ORIGINAL_TRANSLATIONS`: All original translation that were in TRANSLATIONS before apply translation combination with QDEP_TRANSLATIONS from included packages
417417
- `__QDEP_HOOK_FILES`: Paths to header files that contain hook definitions that must be included and loaded by a project
418418
- `__QDEP_EXPORT_QMAKE_INCLUDE_GUARD`: a cache of included exported pri files to ensure each gets included only once
419-
- `__QDEP_LUPDATE`: The generated qmake tool for lupdate, using the `QDEP_LUPDATE_ARGS`
420419

421420
##### Configuration values
422421
- `__qdep_script_version`: The version detected at runtime as reported by the qdep executable

qdep/internal/prf.py

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@
1414
isEmpty(QDEP_GENERATED_TS_DIR): QDEP_GENERATED_TS_DIR = $$QDEP_GENERATED_DIR/.qdepts
1515
debug_and_release:CONFIG(release, debug|release): QDEP_GENERATED_TS_DIR = $${QDEP_GENERATED_TS_DIR}/release
1616
else:debug_and_release:CONFIG(debug, debug|release): QDEP_GENERATED_TS_DIR = $${QDEP_GENERATED_TS_DIR}/debug
17+
isEmpty(QDEP_LUPDATE) {
18+
qtPrepareTool(QDEP_LUPDATE, lupdate)
19+
QDEP_LUPDATE += -recursive -locations relative
20+
qdep_lupdate_no_obsolete: QDEP_LUPDATE += -no-obsolete
21+
}
1722
isEmpty(QDEP_LCONVERT) {
1823
qtPrepareTool(QDEP_LCONVERT, lconvert)
1924
QDEP_LCONVERT += -sort-contexts
@@ -481,12 +486,6 @@
481486
}
482487
483488
# Create lupdate target
484-
isEmpty(QDEP_LUPDATE_ARGS): QDEP_LUPDATE_ARGS = -recursive -locations relative
485-
isEmpty(__QDEP_LUPDATE) {
486-
qtPrepareTool(__QDEP_LUPDATE, lupdate)
487-
__QDEP_LUPDATE += $$QDEP_LUPDATE_ARGS
488-
}
489-
490489
__qdep_lupdate_target.target = lupdate
491490
__qdep_lupdate_target.commands = $$QDEP_LUPDATE $$qdepShellQuote($$_PRO_FILE_PWD_ $$QDEP_LUPDATE_INPUTS) -ts $$qdepShellQuote($$TRANSLATIONS)
492491
__qdep_lupdate_target.depends += $$QDEP_LUPDATE_EXE $$_PRO_FILE_PWD_ $$QDEP_LUPDATE_INPUTS

qdep/qdep.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
from qdep.internal.prf import *
33

44

5-
version = "1.1.0"
5+
version = "1.1.1"
66

77

88
def prfgen(script_path, qmake="qmake", data_dir=None):

0 commit comments

Comments
 (0)