Skip to content

Commit 337034e

Browse files
committed
Switch behavior of one
1 parent 188fd4b commit 337034e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/utils.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,8 @@ for f in (:one, :typemin, :typemax)
114114
Base.$f(::Type{Q}) where {Q<:AbstractQuantity} = $f(Q{DEFAULT_VALUE_TYPE, DEFAULT_DIM_TYPE})
115115
end
116116
if f == :one # Return empty dimensions, as should be multiplicative identity.
117-
@eval Base.$f(q::Q) where {Q<:AbstractQuantity} = new_quantity(Q, $f(ustrip(q)), one(dimension(q)))
117+
# Special behavior as packages use `one` to get an element of the value type:
118+
@eval Base.$f(q::Q) where {Q<:AbstractQuantity} = $f(ustrip(q))
118119
else
119120
@eval Base.$f(q::Q) where {Q<:AbstractQuantity} = new_quantity(Q, $f(ustrip(q)), dimension(q))
120121
end

0 commit comments

Comments
 (0)