React Router can depend on 2 different version of @tanstack/history

[levrik]

As @tanstack/react-router uses ^ range for @tanstack/router-core it can pull in a newer version of @tanstack/router-core and thus also a newer version of @tanstack/history. As @tanstack/react-router itself depends on a specific version of @tanstack/history we can end up with 2 different versions of @tanstack/history when installing an older version. This happens easily with tools like Renovate which can be configured to wait a couple of days before opening a PR for a new version. While I didn't see any immediate issues with this right now after I discovered it on a Renovate PR, I guess it could lead to subtle issues in the future so I wonder if @tanstack/react-router should better depend on a fixed version of @tanstack/router-core or if @tanstack/router-core should define a range for @tanstack/history.

Just install @tanstack/[email protected] as an example. You'll end up with the latest version of @tanstack/router-core and @tanstack/history while still having @tanstack/[email protected] installed as well.

[schiller-manuel]

can you provide a PR to fix this?

[levrik]

sure. could you let me know which one of the 2 options would be preferred?

[schiller-manuel]

I think react-router should depend on a fixed router-core version. but maybe that's debatable
so if you create that PR we can loop in @SeanCassiere

[levrik]

@tanstack/solid-router also depends on a fixed version of @tanstack/router-core so it makes sense to me to align @tanstack/react-router with it.

Opened PR: #3730