From 26fa1a18c608d9c42ecbb9af207c2adb0a7814b4 Mon Sep 17 00:00:00 2001 From: Udoka Date: Fri, 2 Oct 2020 19:48:16 +0100 Subject: [PATCH 1/7] Added Pull_request_template.md --- pull_request_template.md | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 pull_request_template.md diff --git a/pull_request_template.md b/pull_request_template.md new file mode 100644 index 0000000000..bd9668c1f8 --- /dev/null +++ b/pull_request_template.md @@ -0,0 +1,30 @@ +## BUG DESCRIPTION +Clearly describe the problem + +## ROOT CAUSE +Describe the cause and analysis of the problem + +## SOLUTION DESCRIPTION +Describe your code changes in details for reviewers, the solution you provided and how it fixes the issue. +- Note: Reference the issue your pull request solves. +Like; +``` + The pull request fixes issue #issue_number +``` +## Screenshoots +Where necessary add screenshots for your pull request + +## PR Type +What kind of change does this PR introduce? +``` +[ ] Bugfix +[ ] Feature +[ ] Code style update (formatting, local variables) +[ ] Refactoring (no functional changes) +[ ] Build related changes +[ ] Documentation content changes +[ ] Tests +[ ] Other + + +For a guide, on making your pull request, see [Pull_Request](https://github.com) \ No newline at end of file From f8bd34907b1d01737762ae39bb35d368d74560ee Mon Sep 17 00:00:00 2001 From: Udokaku Ugochukwu <63649352+UdokaVrede@users.noreply.github.com> Date: Tue, 6 Oct 2020 11:28:56 +0100 Subject: [PATCH 2/7] Update pull_request_template.md --- pull_request_template.md | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index bd9668c1f8..84d791b738 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -17,14 +17,9 @@ Where necessary add screenshots for your pull request ## PR Type What kind of change does this PR introduce? ``` -[ ] Bugfix -[ ] Feature -[ ] Code style update (formatting, local variables) -[ ] Refactoring (no functional changes) -[ ] Build related changes +[ ] New articles [ ] Documentation content changes -[ ] Tests [ ] Other -For a guide, on making your pull request, see [Pull_Request](https://github.com) \ No newline at end of file +For a guide, on making your pull request, see [Pull_Request](https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request) From af2bb112189b07a3d47a117f4ae46f685cb1ac58 Mon Sep 17 00:00:00 2001 From: Udoka Date: Wed, 7 Oct 2020 07:14:36 +0100 Subject: [PATCH 3/7] New Changes --- pull_request_template.md | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index 84d791b738..ffc55da671 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -1,11 +1,5 @@ -## BUG DESCRIPTION -Clearly describe the problem - -## ROOT CAUSE -Describe the cause and analysis of the problem - ## SOLUTION DESCRIPTION -Describe your code changes in details for reviewers, the solution you provided and how it fixes the issue. +Describe your changes in details for reviewers, the solution you provided and how it fixes the issue. - Note: Reference the issue your pull request solves. Like; ``` @@ -17,8 +11,9 @@ Where necessary add screenshots for your pull request ## PR Type What kind of change does this PR introduce? ``` -[ ] New articles -[ ] Documentation content changes +[ ] Sample program +[ ] Language Documentation content +[ ] Project Documentation content [ ] Other From 4778f73f590586bfff146e77d51db32e58b2aef7 Mon Sep 17 00:00:00 2001 From: Udokaku Ugochukwu <63649352+UdokaVrede@users.noreply.github.com> Date: Thu, 8 Oct 2020 07:50:04 +0100 Subject: [PATCH 4/7] Update pull_request_template.md --- pull_request_template.md | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index ffc55da671..387a8871fd 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -11,10 +11,7 @@ Where necessary add screenshots for your pull request ## PR Type What kind of change does this PR introduce? ``` -[ ] Sample program -[ ] Language Documentation content -[ ] Project Documentation content +[ ] Sample program Documentation +[ ] Language Documentation +[ ] Project Documentation [ ] Other - - -For a guide, on making your pull request, see [Pull_Request](https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request) From 9a3d658b9b01c8ee91dca0d656c4680bc631bff9 Mon Sep 17 00:00:00 2001 From: Jeremy Grifski Date: Thu, 8 Oct 2020 14:18:38 -0400 Subject: [PATCH 5/7] Update pull_request_template.md --- pull_request_template.md | 1 - 1 file changed, 1 deletion(-) diff --git a/pull_request_template.md b/pull_request_template.md index 387a8871fd..748410bd8d 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -10,7 +10,6 @@ Where necessary add screenshots for your pull request ## PR Type What kind of change does this PR introduce? -``` [ ] Sample program Documentation [ ] Language Documentation [ ] Project Documentation From 8abe097060ea0877cd56e50d85f832aa1145c26a Mon Sep 17 00:00:00 2001 From: Jeremy Grifski Date: Thu, 8 Oct 2020 14:21:07 -0400 Subject: [PATCH 6/7] Simplified pull request template --- pull_request_template.md | 27 ++++++++++++--------------- 1 file changed, 12 insertions(+), 15 deletions(-) diff --git a/pull_request_template.md b/pull_request_template.md index 748410bd8d..5281008056 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -1,16 +1,13 @@ -## SOLUTION DESCRIPTION -Describe your changes in details for reviewers, the solution you provided and how it fixes the issue. -- Note: Reference the issue your pull request solves. -Like; -``` - The pull request fixes issue #issue_number -``` -## Screenshoots -Where necessary add screenshots for your pull request +Thanks for helping us build up our knowledge base! +What kind of pull request hav you brought us today? -## PR Type -What kind of change does this PR introduce? -[ ] Sample program Documentation -[ ] Language Documentation -[ ] Project Documentation -[ ] Other +## Pull Request Type + +- [ ] Sample program Documentation +- [ ] Language Documentation +- [ ] Project Documentation +- [ ] Other (explain below) + +## Notes + +Feel free to share any details you feel are relevant. From de2c5fb64ca2079fd158fa5338cd9a754ed9b1cb Mon Sep 17 00:00:00 2001 From: Jeremy Grifski Date: Thu, 8 Oct 2020 14:21:23 -0400 Subject: [PATCH 7/7] Update pull_request_template.md --- pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pull_request_template.md b/pull_request_template.md index 5281008056..68b02fe145 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -3,7 +3,7 @@ What kind of pull request hav you brought us today? ## Pull Request Type -- [ ] Sample program Documentation +- [ ] Sample Program Documentation - [ ] Language Documentation - [ ] Project Documentation - [ ] Other (explain below)