Skip to content

Commit d3f1c90

Browse files
dana-gillTianYi0217
authored andcommitted
fix(editor): Maintain back button when installing community nodes (n8n-io#16069)
1 parent 873f9b5 commit d3f1c90

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

packages/frontend/editor-ui/src/components/Node/NodeCreator/Panel/CommunityNodeDetails.test.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ const getAllNodeCreateElements = vi.fn(() => [
3030

3131
const popViewStack = vi.fn();
3232
const pushViewStack = vi.fn();
33+
const updateCurrentViewStack = vi.fn();
3334

3435
const showError = vi.fn();
3536

@@ -114,6 +115,7 @@ vi.mock('../composables/useViewStacks', () => ({
114115
},
115116
pushViewStack,
116117
popViewStack,
118+
updateCurrentViewStack,
117119
getAllNodeCreateElements,
118120
})),
119121
}));
@@ -148,6 +150,7 @@ describe('CommunityNodeDetails', () => {
148150
expect(fetchCredentialTypes).toHaveBeenCalledWith(true);
149151
expect(getAllNodeCreateElements).toHaveBeenCalled();
150152
expect(popViewStack).toHaveBeenCalled();
153+
expect(updateCurrentViewStack).toHaveBeenCalled();
151154
expect(pushViewStack).toHaveBeenCalledWith(
152155
{
153156
communityNodeDetails: {
@@ -184,7 +187,6 @@ describe('CommunityNodeDetails', () => {
184187
title: 'Node details',
185188
},
186189
{
187-
resetStacks: true,
188190
transitionDirection: 'none',
189191
},
190192
);

packages/frontend/editor-ui/src/components/Node/NodeCreator/Panel/CommunityNodeDetails.vue

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,13 @@ import { prepareCommunityNodeDetailsViewStack, removePreviewToken } from '../uti
1616
1717
import { N8nText } from '@n8n/design-system';
1818
19-
const { activeViewStack, pushViewStack, popViewStack, getAllNodeCreateElements } = useViewStacks();
19+
const {
20+
activeViewStack,
21+
pushViewStack,
22+
popViewStack,
23+
getAllNodeCreateElements,
24+
updateCurrentViewStack,
25+
} = useViewStacks();
2026
2127
const { communityNodeDetails } = activeViewStack;
2228
@@ -37,6 +43,8 @@ const updateViewStack = (key: string) => {
3743
3844
popViewStack();
3945
46+
updateCurrentViewStack({ searchItems: nodeCreatorStore.mergedNodes });
47+
4048
const viewStack = prepareCommunityNodeDetailsViewStack(
4149
installedNode,
4250
getNodeIconSource(installedNode.properties),
@@ -45,7 +53,6 @@ const updateViewStack = (key: string) => {
4553
);
4654
4755
pushViewStack(viewStack, {
48-
resetStacks: true,
4956
transitionDirection: 'none',
5057
});
5158
} else {

0 commit comments

Comments
 (0)