Skip to content

Commit 2b30c3e

Browse files
harshavamsiYeonghyeonKO
authored andcommitted
Hybrid query should call rewrite before creating weight (opensearch-project#1268)
* Hybrid query should call rewrite before creating weight Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Awaits fix Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Rewrite with searcher Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Feature flag issue Signed-off-by: Harsha Vamsi Kalluri <[email protected]> --------- Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: yeonghyeonKo <[email protected]>
1 parent ebc0bc8 commit 2b30c3e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/main/java/org/opensearch/neuralsearch/query/HybridQueryWeight.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public HybridQueryWeight(HybridQuery hybridQuery, IndexSearcher searcher, ScoreM
4747
super(hybridQuery);
4848
weights = hybridQuery.getSubQueries().stream().map(q -> {
4949
try {
50-
return searcher.createWeight(q, scoreMode, boost);
50+
return searcher.createWeight(searcher.rewrite(q), scoreMode, boost);
5151
} catch (IOException e) {
5252
throw new RuntimeException(e);
5353
}

src/test/java/org/opensearch/neuralsearch/plugin/NeuralSearchTests.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,7 @@ public void testQuerySpecs() {
117117
assertTrue(querySpecs.stream().anyMatch(spec -> HybridQueryBuilder.NAME.equals(spec.getName().getPreferredName())));
118118
}
119119

120+
@AwaitsFix(bugUrl = "https://github.com/opensearch-project/OpenSearch/issues/17940")
120121
public void testQueryPhaseSearcher() {
121122
Optional<QueryPhaseSearcher> queryPhaseSearcherWithFeatureFlagDisabled = plugin.getQueryPhaseSearcher();
122123

0 commit comments

Comments
 (0)