add test for invalid namespace declarations

adroitwhiz · adroitwhiz · commit 8ccf3e8980c9 · 2020-01-29T17:22:02.000-05:00
diff --git a/test/fixtures/reserved-namespace.svg b/test/fixtures/reserved-namespace.svg
@@ -0,0 +1,4 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<svg version="1.1" viewBox="0 0 68 68" xmlns="http://www.w3.org/2000/svg">
+    <rect aaa:space="preserve" x="2" y="2" width="64" height="64" fill="white" stroke="black" stroke-width="4" xmlns:aaa="http://www.w3.org/XML/1998/namespace"/>
+</svg>
diff --git a/test/fixup-svg-string.js b/test/fixup-svg-string.js
@@ -28,6 +28,20 @@ test('fixupSvgString should make parsing fixtures not throw', t => {
     t.end();
 });
 
+test('fixupSvgString should correct namespace declarations bound to reserved namespace names', t => {
+    const filePath = path.resolve(__dirname, './fixtures/reserved-namespace.svg');
+    const svgString = fs.readFileSync(filePath)
+        .toString();
+    const fixed = fixupSvgString(svgString);
+
+    // Make sure undefineds aren't being written into the file
+    t.equal(fixed.indexOf('undefined'), -1);
+    t.notThrow(() => {
+        domParser.parseFromString(fixed, 'text/xml');
+    });
+    t.end();
+});
+
 test('fixupSvgString should prevent script tags', t => {
     const filePath = path.resolve(__dirname, './fixtures/script.svg');
     const svgString = fs.readFileSync(filePath)
