React to comments

Signed-off-by: Alexander Batashev <[email protected]>

Author: Alexander Batashev

README.md

@@ -18,8 +18,7 @@ See [LICENSE.txt](sycl/LICENSE.TXT) for details.
 See [CONTRIBUTING.md](CONTRIBUTING.md) for details.
 
 ## Sub-projects Documentation
- - oneAPI Data Parallel C++ compiler - See
-   - [DPC++ Documentation](https://intel.github.io/llvm-docs/)
+ - oneAPI Data Parallel C++ compiler - See [DPC++ Documentation](https://intel.github.io/llvm-docs/)
 
 ## DPC++ extensions
 

sycl/include/CL/sycl/device_selector.hpp

@@ -33,12 +33,7 @@ class __SYCL_EXPORT device_selector {
   virtual int operator()(const device &device) const = 0;
 };
 
-/// The default selector chooses the first available SYCL device. Devices of
-/// different kinds are prioritized in the following order:
-/// 1. GPU
-/// 2. Accelerator
-/// 3. CPU
-/// 4. Host
+/// The default selector chooses the first available SYCL device.
 ///
 /// \sa device
 ///

sycl/include/CL/sycl/event.hpp

@@ -24,7 +24,7 @@ namespace detail {
 class event_impl;
 }
 
-/// An event objects an be used to synchronize memory transfers, enqueues of
+/// An event object can be used to synchronize memory transfers, enqueues of
 /// kernels and signaling barriers.
 ///
 /// \ingroup sycl_api

sycl/include/CL/sycl/id.hpp

@@ -18,8 +18,7 @@ namespace sycl {
 template <int dimensions> class range;
 template <int dimensions, bool with_offset> class item;
 
-/// A vector of dimensions that is used to represent an id into a global or
-/// local range.
+/// A unique identifier of an item in an index space.
 ///
 /// \ingroup sycl_api
 template <int dimensions = 1> class id : public detail::array<dimensions> {
@@ -38,7 +37,7 @@ template <int dimensions = 1> class id : public detail::array<dimensions> {
   class __private_class;
 
   template <typename N, typename T>
-  using EnableIfIntegral  = detail::enable_if_t<std::is_integral<N>::value, T>;
+  using EnableIfIntegral = detail::enable_if_t<std::is_integral<N>::value, T>;
   template <bool B, typename T>
   using EnableIfT = detail::conditional_t<B, T, __private_class>;
 #endif // __SYCL_DISABLE_ID_TO_INT_CONV__
@@ -117,14 +116,14 @@ template <int dimensions = 1> class id : public detail::array<dimensions> {
    * will be "id op size_t"*/
 #define __SYCL_GEN_OPT(op)                                                     \
   template <typename T>                                                        \
-  EnableIfIntegral <T, bool> operator op(const T &rhs) const {                 \
+  EnableIfIntegral<T, bool> operator op(const T &rhs) const {                  \
     if (this->common_array[0] != rhs)                                          \
       return false op true;                                                    \
     return true op true;                                                       \
   }                                                                            \
   template <typename T>                                                        \
-  friend EnableIfIntegral <T, bool> operator op(const T &lhs,                  \
-                                           const id<dimensions> &rhs) {        \
+  friend EnableIfIntegral<T, bool> operator op(const T &lhs,                   \
+                                               const id<dimensions> &rhs) {    \
     if (lhs != rhs.common_array[0])                                            \
       return false op true;                                                    \
     return true op true;                                                       \
@@ -152,15 +151,15 @@ template <int dimensions = 1> class id : public detail::array<dimensions> {
 #define __SYCL_GEN_OPT(op)                                                     \
   __SYCL_GEN_OPT_BASE(op)                                                      \
   template <typename T>                                                        \
-  EnableIfIntegral <T, id<dimensions>> operator op(const T &rhs) const {       \
+  EnableIfIntegral<T, id<dimensions>> operator op(const T &rhs) const {        \
     id<dimensions> result;                                                     \
     for (int i = 0; i < dimensions; ++i) {                                     \
       result.common_array[i] = this->common_array[i] op rhs;                   \
     }                                                                          \
     return result;                                                             \
   }                                                                            \
   template <typename T>                                                        \
-  friend EnableIfIntegral <T, id<dimensions>> operator op(                     \
+  friend EnableIfIntegral<T, id<dimensions>> operator op(                      \
       const T &lhs, const id<dimensions> &rhs) {                               \
     id<dimensions> result;                                                     \
     for (int i = 0; i < dimensions; ++i) {                                     \

sycl/include/CL/sycl/ordered_queue.hpp

@@ -33,8 +33,6 @@ class queue_impl;
 ///
 /// \deprecated Replaced by in_order queue property.
 /// \sa queue
-///
-/// \ingroup sycl_api
 class __SYCL_EXPORT_DEPRECATED("Replaced by in_order queue property")
     ordered_queue {
 public:

sycl/include/CL/sycl/queue.hpp

@@ -32,7 +32,7 @@ namespace detail {
 class queue_impl;
 }
 
-/// Encapsulates a single SYCL queue which shcedules kernels on a SYCL device.
+/// Encapsulates a single SYCL queue which schedules kernels on a SYCL device.
 ///
 /// A SYCL queue can be used to submit command groups to be executed by the SYCL
 /// runtime.
@@ -311,7 +311,7 @@ class __SYCL_EXPORT queue {
   ///
   /// \param Ptr is a USM pointer to the memory to be prefetched to the device.
   /// \param Count is a number of bytes to be prefetched.
-  event prefetch(const void* Ptr, size_t Count) {
+  event prefetch(const void *Ptr, size_t Count) {
     return submit([=](handler &CGH) { CGH.prefetch(Ptr, Count); });
   }
 

sycl/include/CL/sycl/types.hpp

@@ -342,7 +342,7 @@ Applied default alignment.")
 #define SYCL_ALIGNAS(N) alignas(N)
 #endif
 
-/// Provides a cross-patform SIMD vector class tempate that works efficiently on
+/// Provides a cross-patform vector class template that works efficiently on
 /// SYCL devices as well as in host C++ code.
 ///
 /// \ingroup sycl_api

sycl/source/device_selector.cpp

@@ -32,6 +32,11 @@ device device_selector::select_device() const {
                                 PI_DEVICE_NOT_FOUND);
 }
 
+/// Devices of different kinds are prioritized in the following order:
+/// 1. GPU
+/// 2. Accelerator
+/// 3. CPU
+/// 4. Host
 int default_selector::operator()(const device &dev) const {
 
   // Take note of the SYCL_BE environment variable when doing default selection
@@ -42,7 +47,8 @@ int default_selector::operator()(const device &dev) const {
     // information than the driver_version of the device.
     const platform platform = dev.get_info<info::device::platform>();
     const std::string platformVersion =
-        platform.get_info<info::platform::version>();;
+        platform.get_info<info::platform::version>();
+    ;
     // If using PI_CUDA, don't accept a non-CUDA device
     if (platformVersion.find("CUDA") == std::string::npos &&
         backend == "PI_CUDA") {