Skip to content

Commit ee57f1f

Browse files
Improve logging of copy methods (#599)
This commit extracts the log messages of the `BaseConnector` copy methods into separate functions, which can be easily invoked from other `Connector` classes. Tha aim is to uniform the logging messages for all the StreamFLow `Connector` classes. In addition, this commit fixes an issue with remote-to-remote copy inside the `ContainerConnector` logic.
1 parent 1953124 commit ee57f1f

File tree

11 files changed

+250
-337
lines changed

11 files changed

+250
-337
lines changed

examples/flux/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ uses `mpirun`, but since Flux has MPI bindings, we replace this with flux run.
3434
You'll see the streamflow result printed to the screen:
3535

3636
```console
37-
2023-04-02 19:35:18.426 INFO COMPLETED Workflow execution
37+
2023-04-02 19:35:18.426 INFO COMPLETED workflow execution
3838
{
3939
"result": {
4040
"basename": "mpi_output.log",
@@ -49,7 +49,7 @@ You'll see the streamflow result printed to the screen:
4949
}
5050
}
5151
2023-04-02 19:35:18.428 INFO UNDEPLOYING dc-mpi
52-
2023-04-02 19:35:18.443 INFO COMPLETED Undeployment of dc-mpi
52+
2023-04-02 19:35:18.443 INFO COMPLETED undeployment of dc-mpi
5353
```
5454

5555
And the output directory will be in your working directory:

streamflow/cwl/main.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,11 +89,11 @@ async def main(
8989
return
9090
await workflow.save(context)
9191
if logger.isEnabledFor(logging.INFO):
92-
logger.info("COMPLETED Building of workflow execution plan")
92+
logger.info("COMPLETED building of workflow execution plan")
9393
executor = StreamFlowExecutor(workflow)
9494
if logger.isEnabledFor(logging.INFO):
95-
logger.info(f"Running workflow {args.name}")
95+
logger.info(f"EXECUTING workflow {args.name}")
9696
output_tokens = await executor.run()
9797
if logger.isEnabledFor(logging.INFO):
98-
logger.info("COMPLETED Workflow execution")
98+
logger.info("COMPLETED workflow execution")
9999
print(json.dumps(output_tokens, sort_keys=True, indent=4))

0 commit comments

Comments
 (0)