fix: Apply correct port when redirecting to another domain and the app doesn't run behind a proxy#979
Merged
amannn merged 2 commits intoamannn:mainfrom Apr 5, 2024
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@awkaiser-tr is attempting to deploy a commit to the next-intl Team on Vercel. A member of the Team first needs to authorize it. |
Closed
amannn
approved these changes
Apr 5, 2024
Owner
amannn
left a comment
amannn
left a comment
There was a problem hiding this comment.
Perfect PR, thanks a lot! 🙌
to preserve your desired formatting, this project would benefit from an EditorConfig or tool such as Prettier
We currently run Prettier via ESLint, but I know that this workflow is no longer recommended and arguably also something that not many people are familiar with. I agree, it would be better to switch to running Prettier separately.
amannn
changed the title
3 tasks
juanforlizzi
pushed a commit
to juanforlizzi/next-intl
that referenced
this pull request
Jan 16, 2025
…p doesn't run behind a proxy (amannn#979 by @awkaiser-tr) Fixes amannn#658 ---- # Contribution feedback @amannn to preserve your desired formatting, this project would benefit from an [EditorConfig](https://editorconfig.org/) or tool such as [Prettier](https://prettier.io/) --------- Co-authored-by: Jan Amann <jan@amann.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #658
Contribution feedback
@amannn to preserve your desired formatting, this project would benefit from an EditorConfig or tool such as Prettier