chore: add index file tests

Author: amgdev9

app/src/main/kotlin/org/kotlinlsp/index/db/File.kt

@@ -2,7 +2,6 @@ package org.kotlinlsp.index.db
 
 import com.intellij.openapi.project.Project
 import kotlinx.serialization.Serializable
-import org.jetbrains.kotlin.analysis.api.analyze
 import org.jetbrains.kotlin.psi.KtFile
 import org.kotlinlsp.common.read
 import org.kotlinlsp.index.db.adapters.get

app/src/main/kotlin/org/kotlinlsp/index/worker/IndexKtFile.kt

@@ -9,7 +9,6 @@ import org.jetbrains.kotlin.psi.psiUtil.isAbstract
 import org.kotlinlsp.common.read
 import org.kotlinlsp.common.warn
 import org.kotlinlsp.index.db.*
-import java.time.Instant
 
 fun indexKtFile(project: Project, ktFile: KtFile, db: Database) {
     val newFile = File.fromKtFile(ktFile, project, indexed = true)
@@ -20,51 +19,29 @@ fun indexKtFile(project: Project, ktFile: KtFile, db: Database) {
         existingFile?.indexed == true  // Already indexed
     ) return
 
-    // Update the file timestamp and package
-    db.setFile(newFile)
-
     // TODO Remove declarations for this file first
-    project.read {
+    val declarations = project.read {
+        val list = mutableListOf<KtDeclaration>()
         ktFile.accept(object : KtTreeVisitorVoid() {
             override fun visitDeclaration(dcl: KtDeclaration) {
-                val decl = analyze(dcl) {
-                    analyzeDeclaration(newFile.path, dcl)
-                } ?: return
-
-                db.putDeclaration(decl) // TODO Put all declarations in bulk to improve performance
-
+                list.add(dcl)
                 super.visitDeclaration(dcl)
             }
+        })
+        return@read list
+    }
 
-            // TODO Store references
-            /*override fun visitReferenceExpression(e: KtReferenceExpression) {
-                super.visitReferenceExpression(e)
-                if (e !is KtNameReferenceExpression) return
-
-                val target = try {
-                    e.mainReference.resolve()
-                } catch (_: Exception) {
-                    null
-                }
-
-                if (target == null) {
-                    warn("Unresolved reference: ${e.text}")
-                    return
-                }
-
-                val referenceRecord = ReferenceRecord(
-                    id = -1,
-                    symbolId = 1,
-                    startOffset = e.textOffset,
-                    endOffset = e.endOffset
-                )
+    declarations.forEach {
+        val record = analyze(it) {
+            analyzeDeclaration(newFile.path, it)
+        } ?: return@forEach
 
-                debug("REFERENCE: $referenceRecord")
-                debug("-> Name: ${e.text}")
-                debug("-> Target: ${target?.containingFile?.virtualFile?.url}")
-            }*/
-        })
+        // TODO Put all declarations in bulk to improve performance
+        db.putDeclaration(record)
     }
+
+    // Update the file timestamp and package
+    db.setFile(newFile)
 }
 
 private fun KaSession.analyzeDeclaration(path: String, dcl: KtDeclaration): Declaration? {

app/src/test/kotlin/org/kotlinlsp/index/FileTests.kt

@@ -0,0 +1,77 @@
+package org.kotlinlsp.index
+
+import org.junit.jupiter.api.Assertions.assertEquals
+import org.junit.jupiter.params.ParameterizedTest
+import org.junit.jupiter.params.provider.Arguments
+import org.junit.jupiter.params.provider.MethodSource
+import org.kotlinlsp.index.db.File
+import java.time.Instant
+import java.util.stream.Stream
+
+class FileTests {
+    companion object {
+        @JvmStatic
+        fun provideData(): Stream<Arguments> = Stream.of(
+            // Unmodified file
+            Arguments.of(
+                buildFile(modificationStamp = 0, lastModified = Instant.ofEpochMilli(100)),
+                buildFile(modificationStamp = 0, lastModified = Instant.ofEpochMilli(100)),
+                true
+            ),
+            // File modified on disk
+            Arguments.of(
+                buildFile(modificationStamp = 0, lastModified = Instant.ofEpochMilli(50)),
+                buildFile(modificationStamp = 0, lastModified = Instant.ofEpochMilli(100)),
+                false
+            ),
+            // File modified in memory
+            Arguments.of(
+                buildFile(modificationStamp = 0, lastModified = Instant.ofEpochMilli(50)),
+                buildFile(modificationStamp = 1, lastModified = Instant.ofEpochMilli(100)),
+                false
+            ),
+            Arguments.of(
+                buildFile(modificationStamp = 1, lastModified = Instant.ofEpochMilli(50)),
+                buildFile(modificationStamp = 2, lastModified = Instant.ofEpochMilli(100)),
+                false
+            ),
+            // Reloading file from disk (after being edited in memory but not saved)
+            Arguments.of(
+                buildFile(modificationStamp = 10, lastModified = Instant.ofEpochMilli(100)),
+                buildFile(modificationStamp = 0, lastModified = Instant.ofEpochMilli(100)),
+                false
+            ),
+            // Old in memory file trying to be indexed
+            Arguments.of(
+                buildFile(modificationStamp = 10, lastModified = Instant.ofEpochMilli(50)),
+                buildFile(modificationStamp = 9, lastModified = Instant.ofEpochMilli(50)),
+                true
+            ),
+            // New file should always be indexed
+            Arguments.of(
+                null,
+                buildFile(modificationStamp = 9, lastModified = Instant.ofEpochMilli(50)),
+                false
+            ),
+        )
+    }
+
+    @ParameterizedTest
+    @MethodSource("provideData")
+    fun `test file index skip logic`(existingFile: File?, newFile: File, result: Boolean) {
+        assertEquals(File.shouldBeSkipped(existingFile = existingFile, newFile = newFile), result)
+    }
+
+}
+
+private fun buildFile(lastModified: Instant, modificationStamp: Long, indexed: Boolean = false): File {
+    val path = "/sample/path.kt"
+    val packageFqName = "com.example"
+    return File(
+        path = path,
+        modificationStamp = modificationStamp,
+        packageFqName = packageFqName,
+        lastModified = lastModified,
+        indexed = indexed
+    )
+}