Skip to content

Commit 5407ff0

Browse files
authored
Merge pull request #61 from Mutant-Slayer/fix/scroll-state
[Fix] scroll state fixed for color bot in landscape mode
2 parents a321f4d + 6ac4ec1 commit 5407ff0

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

feature/creation/src/main/java/com/android/developers/androidify/creation/AndroidBotColorPicker.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,9 @@ import androidx.compose.foundation.layout.height
3333
import androidx.compose.foundation.layout.requiredSize
3434
import androidx.compose.foundation.layout.size
3535
import androidx.compose.foundation.layout.wrapContentHeight
36+
import androidx.compose.foundation.rememberScrollState
3637
import androidx.compose.foundation.shape.RoundedCornerShape
38+
import androidx.compose.foundation.verticalScroll
3739
import androidx.compose.material3.ExperimentalMaterial3ExpressiveApi
3840
import androidx.compose.material3.Icon
3941
import androidx.compose.material3.MaterialTheme
@@ -61,6 +63,7 @@ fun AndroidBotColorPicker(
6163
onBotColorSelected: (BotColor) -> Unit,
6264
listBotColor: List<BotColor>,
6365
) {
66+
val scrollState = rememberScrollState()
6467
Column(
6568
modifier
6669
.fillMaxWidth()
@@ -73,7 +76,9 @@ fun AndroidBotColorPicker(
7376
FlowRow(
7477
horizontalArrangement = Arrangement.spacedBy(12.dp),
7578
verticalArrangement = Arrangement.spacedBy(12.dp),
76-
modifier = Modifier.align(Alignment.CenterHorizontally),
79+
modifier = Modifier
80+
.align(Alignment.CenterHorizontally)
81+
.verticalScroll(scrollState),
7782
) {
7883
listBotColors.forEach {
7984
AndroidBotIndividualColor(

feature/home/src/main/java/com/android/developers/androidify/home/AboutScreen.kt

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,8 @@ fun AboutScreen(
9292
Scaffold(
9393
topBar = {
9494
IconButton(
95-
modifier = Modifier.safeDrawingPadding()
95+
modifier = Modifier
96+
.safeDrawingPadding()
9697
.padding(16.dp),
9798
shape = CircleShape,
9899
colors = IconButtonDefaults.iconButtonColors(
@@ -162,7 +163,7 @@ fun AboutScreen(
162163
)
163164
}
164165
Spacer(Modifier.size(48.dp))
165-
FooterButtons()
166+
FooterButtons(modifier = Modifier.padding(bottom = 8.dp))
166167
}
167168
}
168169
} else {
@@ -196,17 +197,17 @@ fun AboutScreen(
196197
stringResource(R.string.about_step3_label),
197198
)
198199
Spacer(modifier = Modifier.size(24.dp))
199-
FooterButtons()
200+
FooterButtons(modifier = Modifier.padding(bottom = 8.dp))
200201
}
201202
}
202203
}
203204
}
204205
}
205206

206207
@Composable
207-
private fun FooterButtons() {
208+
private fun FooterButtons(modifier: Modifier = Modifier) {
208209
val uriHandler = LocalUriHandler.current
209-
Row {
210+
Row(modifier) {
210211
SecondaryOutlinedButton(
211212
onClick = {
212213
uriHandler.openUri("https://policies.google.com/terms")

0 commit comments

Comments
 (0)