Skip to content

Commit 2d7120f

Browse files
committed
fix(tweakpane): use default tweakpane parent element
1 parent 050aee5 commit 2d7120f

File tree

1 file changed

+1
-13
lines changed

1 file changed

+1
-13
lines changed

libs/tweakpane/src/lib/pane.ts

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import { afterNextRender, DestroyRef, Directive, effect, inject, input, isSignal, signal } from '@angular/core';
2-
import { injectStore } from 'angular-three';
32
import { Pane } from 'tweakpane';
43
import { NgtTweakFolder } from './folder';
54
import { NgtTweakTitle } from './title';
@@ -17,25 +16,17 @@ export class NgtTweakPane {
1716

1817
private title = inject(NgtTweakTitle, { host: true });
1918
private folder = inject(NgtTweakFolder, { host: true });
20-
private store = injectStore();
2119
private pane = signal<Pane | null>(null);
2220

2321
constructor() {
2422
this.folder.isSelf = false;
2523

2624
afterNextRender(() => {
27-
// the ngt-canvas
28-
const parentElement = this.store.snapshot.gl.domElement.parentElement?.parentElement;
29-
3025
const pane = new Pane({
3126
title: this.title.title(),
3227
expanded: this.folder.expanded(),
3328
});
3429

35-
if (parentElement && pane.element.parentElement) {
36-
parentElement.appendChild(pane.element.parentElement);
37-
}
38-
3930
this.pane.set(pane);
4031
this.folder.parentFolder.set(pane);
4132
});
@@ -44,10 +35,7 @@ export class NgtTweakPane {
4435
const pane = this.pane();
4536
if (!pane) return;
4637

47-
const parentElement = this.store.snapshot.gl.domElement.parentElement?.parentElement;
48-
if (!parentElement || !pane.element.parentElement) return;
49-
50-
pane.element.parentElement.remove();
38+
pane.element.remove();
5139
});
5240

5341
effect(() => {

0 commit comments

Comments
 (0)