Skip to content

Commit 3ba5a73

Browse files
committed
fix(core): ng20 resource
1 parent 8227b3c commit 3ba5a73

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

libs/core/src/lib/loader-resource.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ function normalizeInputs(input: string | string[] | Record<string, string>) {
2828
const cached = new Map();
2929
const memoizedLoaders = new WeakMap();
3030

31-
function getLoaderRequestParams<
31+
function getLoaderResourceParams<
3232
TData,
3333
TUrl extends string | string[] | Record<string, string>,
3434
TLoaderConstructor extends NgtLoaderProto<TData>,
@@ -54,16 +54,16 @@ function getLoaderRequestParams<
5454
}
5555

5656
function getLoaderPromises<TData, TUrl extends string | string[] | Record<string, string>>(
57-
request: { loader: THREE.Loader<TData>; normalizedUrls: string[]; urls: TUrl },
57+
params: { loader: THREE.Loader<TData>; normalizedUrls: string[]; urls: TUrl },
5858
onProgress?: { (event: ProgressEvent<EventTarget>): void },
5959
) {
60-
return request.normalizedUrls.map((url) => {
60+
return params.normalizedUrls.map((url) => {
6161
if (url === '') return Promise.resolve(null);
6262
const cachedPromise = cached.get(url);
6363
if (cachedPromise) return cachedPromise;
6464

6565
const promise = new Promise<TData>((res, rej) => {
66-
request.loader.load(
66+
params.loader.load(
6767
url,
6868
(data) => {
6969
if ('scene' in (data as NgtAnyRecord)) {
@@ -109,29 +109,29 @@ export function loaderResource<
109109
> {
110110
return assertInjector(loaderResource, injector, () => {
111111
return resource({
112-
request: () => getLoaderRequestParams(input, loaderConstructorFactory, extensions),
113-
loader: async ({ request }) => {
112+
params: () => getLoaderResourceParams(input, loaderConstructorFactory, extensions),
113+
loader: async ({ params }) => {
114114
// TODO: use the abortSignal when THREE.Loader supports it
115115

116-
const loadedResults = await Promise.all(getLoaderPromises(request, onProgress));
116+
const loadedResults = await Promise.all(getLoaderPromises(params, onProgress));
117117

118118
let results: NgtLoaderResults<
119119
TUrl,
120120
NgtBranchingReturn<TReturn, NgtGLTFLike, NgtGLTFLike & NgtObjectMap>
121121
>;
122122

123-
if (Array.isArray(request.urls)) {
123+
if (Array.isArray(params.urls)) {
124124
results = loadedResults as NgtLoaderResults<
125125
TUrl,
126126
NgtBranchingReturn<TReturn, NgtGLTFLike, NgtGLTFLike & NgtObjectMap>
127127
>;
128-
} else if (typeof request.urls === 'string') {
128+
} else if (typeof params.urls === 'string') {
129129
results = loadedResults[0] as NgtLoaderResults<
130130
TUrl,
131131
NgtBranchingReturn<TReturn, NgtGLTFLike, NgtGLTFLike & NgtObjectMap>
132132
>;
133133
} else {
134-
const keys = Object.keys(request.urls);
134+
const keys = Object.keys(params.urls);
135135
results = keys.reduce(
136136
(result, key) => {
137137
// @ts-ignore
@@ -161,7 +161,7 @@ loaderResource.preload = <
161161
inputs: TUrl,
162162
extensions?: NgtLoaderExtensions<TLoaderConstructor>,
163163
) => {
164-
const params = getLoaderRequestParams(
164+
const params = getLoaderResourceParams(
165165
() => inputs,
166166
() => loaderConstructor,
167167
extensions,

0 commit comments

Comments
 (0)