fix: refactor RulesCollection to always require app argument

This change reduce use of get_app in codebase as this can cause
unexpected behaviors for tests and also at runtime.

Related: AAP-60425

Author: ssbarnea

.config/requirements-lock.txt

@@ -1,5 +1,5 @@
 # This file was autogenerated by uv via the following command:
-#    uv export --no-dev --no-emit-package ansible-core --no-emit-package resolvelib --no-emit-package ruamel-yaml-clib --no-emit-package tomli --no-emit-package typing-extensions --no-emit-project --no-hashes -o .config/requirements-lock.txt
+#    uv export --no-default-groups --no-dev --no-emit-package ansible-core --no-emit-package resolvelib --no-emit-package ruamel-yaml-clib --no-emit-package tomli --no-emit-package typing-extensions --no-emit-project --no-hashes -o .config/requirements-lock.txt
 ansible-compat==25.12.0
     # via ansible-lint
 attrs==25.4.0

.pre-commit-config.yaml

@@ -30,7 +30,7 @@ repos:
     hooks:
       - id: check-useless-excludes
   - repo: https://github.com/astral-sh/uv-pre-commit
-    rev: 0.9.21
+    rev: 0.9.22
     hooks:
       - id: uv-sync
       - id: uv-lock
@@ -42,6 +42,7 @@ repos:
       - id: uv-export
         name: "deps: regenerate requirements-lock.txt for actions"
         args:
+          - "--no-default-groups"
           - "--no-dev"
           - "--no-emit-package"
           - ansible-core
@@ -146,7 +147,7 @@ repos:
         entry: yamllint --strict
 
   - repo: https://github.com/tombi-toml/tombi-pre-commit
-    rev: v0.7.14
+    rev: v0.7.15
     hooks:
       - id: tombi-format
         alias: toml
@@ -160,6 +161,7 @@ repos:
         alias: ruff
       - id: ruff-check
         alias: ruff
+        args: ["--unsafe-fixes"]
   - repo: https://github.com/pre-commit/mirrors-mypy
     rev: v1.19.1
     hooks:

pyproject.toml

@@ -103,6 +103,7 @@ lint = [
   "pre-commit>=4.1",
   "pre-commit-uv>=4.1.4",
   "pytest>=9",
+  "ruff>=0.14.10",
   "setuptools>=51.1.1",
 ]
 pkg = [
@@ -873,6 +874,7 @@ PRE_COMMIT_COLOR = "always"
 
 [tool.uv]
 package = true
+default-groups = "all"
 
 [tool.vulture]
 exclude = [

src/ansiblelint/__main__.py

@@ -376,9 +376,9 @@ def main(argv: list[str] | None = None) -> int:
         cached=True,
     )  # to be sure we use the offline value from settings
     rules = RulesCollection(
-        options.rulesdirs,
-        profile_name=options.profile,
         app=app,
+        rulesdirs=options.rulesdirs,
+        profile_name=options.profile,
         options=options,
     )
 

src/ansiblelint/app.py

@@ -7,7 +7,6 @@
 import logging
 import os
 import sys
-from functools import lru_cache
 from pathlib import Path
 from typing import TYPE_CHECKING, Any
 
@@ -387,7 +386,6 @@ def _sanitize_list_options(tag_list: list[str]) -> list[str]:
     return sorted(set(tags))
 
 
-@lru_cache
 def get_app(*, offline: bool | None = None, cached: bool = False) -> App:
     """Return the application instance, caching the return value."""
     # Avoids ever running the app initialization twice if cached argument

src/ansiblelint/config.py

@@ -314,6 +314,11 @@ def get_version_warning() -> str:
         release_url = (
             "https://api.github.com/repos/ansible/ansible-lint/releases/latest"
         )
+        if not release_url.startswith(
+            "https://"
+        ):  # pragma: no cover (ruff compatibility)
+            msg = "release_url must start with https://"
+            raise ValueError(msg)
         try:
             with urllib.request.urlopen(release_url) as url:
                 data = json.load(url)

src/ansiblelint/rules/__init__.py

@@ -23,7 +23,6 @@
     RuntimeErrorRule,
     WarningRule,
 )
-from ansiblelint.app import App, get_app
 from ansiblelint.config import PROFILES, Options
 from ansiblelint.config import options as default_options
 from ansiblelint.constants import RULE_DOC_URL, SKIPPED_RULES_KEY
@@ -33,6 +32,7 @@
 if TYPE_CHECKING:
     from ruamel.yaml.comments import CommentedMap, CommentedSeq
 
+    from ansiblelint.app import App
     from ansiblelint.errors import RuleMatchTransformMeta
 
 _logger = logging.getLogger(__name__)
@@ -390,12 +390,12 @@ class RulesCollection:
 
     def __init__(  # pylint: disable=too-many-arguments
         self,
+        app: App,
         rulesdirs: list[str] | list[Path] | None = None,
         options: Options | None = None,
         profile_name: str | None = None,
         *,
         conditional: bool = True,
-        app: App | None = None,
     ) -> None:
         """Initialize a RulesCollection instance."""
         if options is None:
@@ -406,10 +406,7 @@ def __init__(  # pylint: disable=too-many-arguments
         else:
             self.options = options
         self.profile = []
-        # app should be defined on normal run logic, but for testing we might
-        # not pass it, and in this case we assume offline mode for performance
-        # reasons.
-        self.app = app or get_app(offline=True)
+        self.app = app
 
         if profile_name:
             self.profile = PROFILES[profile_name]

src/ansiblelint/rules/complexity.py

@@ -9,6 +9,7 @@
 from ansiblelint.rules import AnsibleLintRule, RulesCollection
 
 if TYPE_CHECKING:
+    from ansiblelint.app import App
     from ansiblelint.config import Options
     from ansiblelint.errors import MatchError
     from ansiblelint.file_utils import Lintable
@@ -100,11 +101,12 @@ def test_complexity(
         expected_results: list[str],
         monkeypatch: pytest.MonkeyPatch,
         config_options: Options,
+        app: App,
     ) -> None:
         """Test rule."""
         monkeypatch.setattr(config_options, "max_tasks", 5)
         monkeypatch.setattr(config_options, "max_block_depth", 3)
-        collection = RulesCollection(options=config_options)
+        collection = RulesCollection(app=app, options=config_options)
         collection.register(ComplexityRule())
         results = Runner(file, rules=collection).run()
 

src/ansiblelint/rules/name.py

@@ -15,6 +15,7 @@
 if TYPE_CHECKING:
     from ruamel.yaml.comments import CommentedMap, CommentedSeq
 
+    from ansiblelint.app import App
     from ansiblelint.config import Options
     from ansiblelint.errors import MatchError
     from ansiblelint.utils import Task
@@ -324,10 +325,10 @@ def test_file_negative(empty_rule_collection: RulesCollection) -> None:
         errs = bad_runner.run()
         assert len(errs) == 5
 
-    def test_name_prefix_positive(config_options: Options) -> None:
+    def test_name_prefix_positive(config_options: Options, app: App) -> None:
         """Positive test for name[prefix]."""
         config_options.enable_list = ["name[prefix]"]
-        collection = RulesCollection(options=config_options)
+        collection = RulesCollection(app=app, options=config_options)
         collection.register(NameRule())
         success = Lintable(
             "examples/playbooks/tasks/main.yml",
@@ -337,10 +338,10 @@ def test_name_prefix_positive(config_options: Options) -> None:
         results = good_runner.run()
         assert len(results) == 0
 
-    def test_name_prefix_negative(config_options: Options) -> None:
+    def test_name_prefix_negative(config_options: Options, app: App) -> None:
         """Negative test for name[missing]."""
         config_options.enable_list = ["name[prefix]"]
-        collection = RulesCollection(options=config_options)
+        collection = RulesCollection(app=app, options=config_options)
         collection.register(NameRule())
         failure = Lintable(
             "examples/playbooks/tasks/rule-name-prefix-fail.yml",
@@ -354,10 +355,10 @@ def test_name_prefix_negative(config_options: Options) -> None:
         assert results[1].tag == "name[prefix]"
         assert results[2].tag == "name[prefix]"
 
-    def test_name_prefix_negative_2(config_options: Options) -> None:
+    def test_name_prefix_negative_2(config_options: Options, app: App) -> None:
         """Negative test for name[prefix]."""
         config_options.enable_list = ["name[prefix]"]
-        collection = RulesCollection(options=config_options)
+        collection = RulesCollection(app=app, options=config_options)
         collection.register(NameRule())
         failure = Lintable(
             "examples/playbooks/tasks/partial_prefix/foo.yml",
@@ -369,10 +370,10 @@ def test_name_prefix_negative_2(config_options: Options) -> None:
         assert results[0].tag == "name[prefix]"
         assert results[1].tag == "name[prefix]"
 
-    def test_name_prefix_negative_3(config_options: Options) -> None:
+    def test_name_prefix_negative_3(config_options: Options, app: App) -> None:
         """Negative test for name[prefix]."""
         config_options.enable_list = ["name[prefix]"]
-        collection = RulesCollection(options=config_options)
+        collection = RulesCollection(app=app, options=config_options)
         collection.register(NameRule())
         failure = Lintable(
             "examples/playbooks/tasks/partial_prefix/main.yml",

src/ansiblelint/rules/no_log_password.py

@@ -29,6 +29,7 @@
 if TYPE_CHECKING:
     from ruamel.yaml.comments import CommentedMap, CommentedSeq
 
+    from ansiblelint.app import App
     from ansiblelint.config import Options
     from ansiblelint.errors import MatchError
     from ansiblelint.file_utils import Lintable
@@ -332,11 +333,12 @@ def test_password_lock_false(rule_runner: RunFromText) -> None:
     @mock.patch.dict(os.environ, {"ANSIBLE_LINT_WRITE_TMP": "1"}, clear=True)
     def test_no_log_password_transform(
         config_options: Options,
+        app: App,
     ) -> None:
         """Test transform functionality for no-log-password rule."""
         playbook = Path("examples/playbooks/transform-no-log-password.yml")
         config_options.write_list = ["all"]
-        rules = RulesCollection(options=config_options)
+        rules = RulesCollection(app=app, options=config_options)
         rules.register(NoLogPasswordsRule())
 
         config_options.lintables = [str(playbook)]