fix: resolve auto-fix failures and detection for short module names (#4750)

Author: Jkhall81

examples/playbooks/rule-no-free-form-fail.yml

@@ -14,3 +14,12 @@
       ansible.builtin.raw:
         args: "123"
       changed_when: false
+
+    - name: Short name with multiple params (Issue 4750)
+      file: path=/tmp/short1 state=directory mode=0755
+
+    - name: FQCN builtin with free-form
+      ansible.builtin.uri: url=http://example.com return_content=yes
+
+    - name: Short name without a task name
+      template: src=foo.j2 dest=/tmp/foo

src/ansiblelint/rules/no_free_form.py

@@ -92,6 +92,7 @@ def matchtask(
                         message=f"Avoid using free-form when calling module actions. ({action})",
                         lineno=task.line,
                         filename=file,
+                        details=action,
                     ),
                 )
         return results
@@ -125,7 +126,10 @@ def filter_values(
                 if v[0] in "\"'":
                     # Keep quoted strings together
                     quote = v[0]
-                    _, v, remainder = v.split(quote, 2)
+                    try:
+                        _, v, remainder = v.split(quote, 2)
+                    except ValueError:
+                        return val
                     v = (
                         DoubleQuotedScalarString
                         if quote == '"'
@@ -146,10 +150,12 @@ def filter_values(
 
             if match.tag == "no-free-form":
                 module_opts: dict[str, Any] = {}
+                target_module = match.details
+
                 for _ in range(len(task)):
                     k, v = task.popitem(False)
                     # identify module as key and process its value
-                    if len(k.split(".")) == 3 and isinstance(v, str):
+                    if k == target_module and isinstance(v, str):
                         cmd = filter_values(v, "=", module_opts)
                         if cmd:
                             module_opts["cmd"] = cmd
@@ -196,7 +202,7 @@ def filter_values(
         ("file", "expected"),
         (
             pytest.param("examples/playbooks/rule-no-free-form-pass.yml", 0, id="pass"),
-            pytest.param("examples/playbooks/rule-no-free-form-fail.yml", 3, id="fail"),
+            pytest.param("examples/playbooks/rule-no-free-form-fail.yml", 6, id="fail"),
         ),
     )
     def test_rule_no_free_form(
@@ -207,6 +213,26 @@ def test_rule_no_free_form(
         """Validate that rule works as intended."""
         results = Runner(file, rules=default_rules_collection).run()
 
-        for result in results:
+        rule_results = [r for r in results if r.rule.id == NoFreeFormRule.id]
+
+        for result in rule_results:
             assert result.rule.id == NoFreeFormRule.id, result
-        assert len(results) == expected
+        assert len(rule_results) == expected
+
+    def test_no_free_form_transform_error_handling() -> None:
+        """Test that transform handles malformed quoted strings."""
+        from ruamel.yaml.comments import CommentedMap
+
+        from ansiblelint.errors import MatchError
+
+        rule = NoFreeFormRule()
+        task = CommentedMap({"ansible.builtin.shell": 'chdir=" /tmp echo foo'})
+        match = MatchError(
+            message="test",
+            rule=rule,
+            details="ansible.builtin.shell",
+            tag="no-free-form",
+        )
+
+        rule.transform(match, None, task)  # type: ignore[arg-type]
+        assert task["ansible.builtin.shell"] == {"cmd": 'chdir=" /tmp echo foo'}

src/ansiblelint/schemas/__store__.json

@@ -4,7 +4,7 @@
     "url": "https://raw.githubusercontent.com/ansible/ansible-lint/main/src/ansiblelint/schemas/ansible-lint-config.json"
   },
   "ansible-navigator-config": {
-    "etag": "730a0572f872af3ce271fb5116bc9d4609da10dc2e35448b5ec1050f12b72e2b",
+    "etag": "5f454fdaeb3d92c4bb2cc15dcc48faa67925fecfbdb72efffeddee01860d6bcb",
     "url": "https://raw.githubusercontent.com/ansible/ansible-navigator/main/src/ansible_navigator/data/ansible-navigator.json"
   },
   "changelog": {
@@ -24,7 +24,7 @@
     "url": "https://raw.githubusercontent.com/ansible/ansible-lint/main/src/ansiblelint/schemas/inventory.json"
   },
   "meta": {
-    "etag": "fa83d61b00b254d54a7c9a69e4fb8b722f356adec906da7beb733cadda1342bc",
+    "etag": "2f5c7deb174136b48a4bc1d8d4399b1a175379dd4b8a863baa9c9bd56ffda489",
     "url": "https://raw.githubusercontent.com/ansible/ansible-lint/main/src/ansiblelint/schemas/meta.json"
   },
   "meta-runtime": {

src/ansiblelint/schemas/ansible-navigator-config.json

@@ -1,7 +1,7 @@
 {
     "$schema": "http://json-schema.org/draft-07/schema",
     "additionalProperties": false,
-    "description": "See https://docs.ansible.com/projects/navigator/settings/",
+    "description": "See https://ansible.readthedocs.io/projects/navigator/settings/",
     "properties": {
         "ansible-navigator": {
             "additionalProperties": false,
@@ -525,7 +525,7 @@
     "required": [
         "ansible-navigator"
     ],
-    "title": "ansible-navigator settings v25",
+    "title": "ansible-navigator settings v26",
     "type": "object",
-    "version": "25"
+    "version": "26"
 }