Merge pull request #2 from anthonycorbacho/feat/rework-http-call

Use global http client

Author: anthonycorbacho

slack.go

@@ -2,32 +2,33 @@ package slack
 
 import (
 	"bytes"
-	"crypto/tls"
 	"encoding/json"
 	"fmt"
 	"net/http"
+	"time"
 )
 
+// _httpClient is a default http client that is going to be reuse
+var _httpClient = &http.Client{
+	Transport: &http.Transport{
+		MaxIdleConnsPerHost: 20,
+	},
+	Timeout: 10 * time.Second,
+}
+
 // Send sends message (Payload) to the given slack hook URL.
 func Send(hookURL string, message Message) error {
 	bts, err := json.Marshal(message)
 	if err != nil {
 		return ErrSerializeMessage
 	}
 
-	tr := &http.Transport{
-		TLSClientConfig: &tls.Config{
-			InsecureSkipVerify: true,
-		},
-	}
-
-	client := &http.Client{Transport: tr}
 	req, err := http.NewRequest("POST", hookURL, bytes.NewReader(bts))
 	if err != nil {
 		return ErrCreateRequest
 	}
 
-	res, err := client.Do(req)
+	res, err := _httpClient.Do(req)
 	if err != nil {
 		return ErrSendingRequest
 	}

slack_test.go

@@ -33,7 +33,7 @@ func testHandler(w http.ResponseWriter, r *http.Request) {
 	}
 }
 
-func Test_slack(t *testing.T) {
+func TestSlack(t *testing.T) {
 	srv := httptest.NewServer(handler())
 	defer srv.Close()