fix(hono): preserve parameter name as defined in the OAS (#1921)

* fix: preserve parameter name as defined in the OAS.

* style: remove unnecessary parenthesis

* fix(hono): fix param types

* chore(hono): update hono-with-zod sample

* chore(hono): update hono-with-fetch-client sample

* chore(hono): remove /cats/cat_id endpoint from yaml

* chore(hono): remove cat definition

* chore(hono): remove cat handler

Author: manakuro

packages/hono/src/index.ts

@@ -18,6 +18,9 @@ import {
   NormalizedOutputOptions,
   pascal,
   upath,
+  getParamsInPath,
+  sanitize,
+  camel,
 } from '@orval/core';
 import { generateZod } from '@orval/zod';
 import fs from 'fs-extra';
@@ -542,11 +545,22 @@ const factory = createFactory();`;
 };
 
 const getContext = (verbOption: GeneratorVerbOptions) => {
-  const paramType = verbOption.params.length
-    ? `param: {\n ${verbOption.params
-        .map((property) => property.definition)
-        .join(',\n    ')},\n },`
-    : '';
+  let paramType = '';
+  if (verbOption.params.length) {
+    const params = getParamsInPath(verbOption.pathRoute).map((name) => {
+      const param = verbOption.params.find(
+        (p) => p.name === sanitize(camel(name), { es5keyword: true }),
+      );
+      const definition = param?.definition.split(':')[1];
+      const required = param?.required ?? false;
+      return {
+        definition: `${name}${!required ? '?' : ''}:${definition}`,
+      };
+    });
+    paramType = `param: {\n ${params
+      .map((property) => property.definition)
+      .join(',\n    ')},\n },`;
+  }
 
   const queryType = verbOption.queryParams
     ? `query: ${verbOption.queryParams?.schema.name},`

packages/hono/src/route.ts

@@ -1,4 +1,4 @@
-import { camel, sanitize } from '@orval/core';
+import { sanitize } from '@orval/core';
 
 const hasParam = (path: string): boolean => /[^{]*{[\w*_-]*}.*/.test(path);
 
@@ -7,7 +7,7 @@ const getRoutePath = (path: string): string => {
   if (!matches?.length) return path; // impossible due to regexp grouping here, but for TS
 
   const prev = matches[1];
-  const param = sanitize(camel(matches[2]), {
+  const param = sanitize(matches[2], {
     es5keyword: true,
     underscore: true,
     dash: true,