Skip to content

Newfeature/login #3761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

rushidharbvraju
Copy link

INSERT HERE a clear and concise description of what the pull request is for along with a reference to the associated issue IDs, if they exist.

Important

Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise.

Checklist

Before we can review and merge your changes, please go through the checklist below. If you're still working on some items, feel free to submit your pull request as a draft—our CI will help guide you through the remaining steps.

✅ Required checks

  • License: I confirm that my changes are submitted under the Apache License, Version 2.0.

  • Commit signatures: All commits are signed and verifiable. (See GitHub Docs on Commit Signature Verification).

  • Code formatting: The code is formatted according to the project’s style guide.

    How to check and fix formatting
    • To check formatting: ./mvnw spotless:check
    • To fix formatting: ./mvnw spotless:apply

    See the build instructions for details.

  • Build & Test: I verified that the project builds and all unit tests pass.

    How to build the project

    Run: ./mvnw verify

    See the build instructions for details.

🧪 Tests (select one)

  • I have added or updated tests to cover my changes.
  • No additional tests are needed for this change.

📝 Changelog (select one)

  • I added a changelog entry in src/changelog/.2.x.x. (See Changelog Entry File Guide).
  • This is a trivial change and does not require a changelog entry.

@ppkarwasz
Copy link
Contributor

Thank you for the contribution.

However, this PR appears to only remove the executable permission from a few shell scripts, and it does not include any explanation or rationale for why you consider this change necessary.

If there is a specific issue or motivation behind this update, please feel free to provide more details so we can better evaluate it. In the absence of that, I'm going to close this PR for now.

@ppkarwasz ppkarwasz closed this Jun 19, 2025
@github-project-automation github-project-automation bot moved this from To triage to Done in Log4j bug tracker Jun 19, 2025
@rushidharbvraju rushidharbvraju deleted the newfeature/login branch July 7, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants