jakarta-web relax the import package constraints #3791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by gradle/develocity-actions |
|
hmm what is exactly the problem? should i add some spaces somewhere or remove some? |
|
It is a formatting problem, run: ./mvnw spotless:applyto fix it and push the changes. |
auto-merge was automatically disabled
June 30, 2025 16:00
Head branch was pushed to by a user without write access
jcompagner
force-pushed
the
jakarta_web_import
branch
from
7368f0d to
329a0f2
Compare
jcompagner
force-pushed
the
jakarta_web_import
branch
from
329a0f2 to
3522618
Compare
|
A snapshot should be ready as soon as the workflow finishes: https://github.com/apache/logging-log4j2/actions/runs/15978983571 |
| type="changed"> | ||
| <issue id="3787" link="https://github.com/apache/logging-log4j2/issues/3787"/> | ||
| <description format="asciidoc"> | ||
| add a bnd tool property that makes sure that the supported jakarta version has a wider range then 5 to 6 |
There was a problem hiding this comment.
Thanks, I'll keep it mind, while reviewing the changelog entries for the release.
ppkarwasz
pushed a commit
that referenced
this pull request
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3787
Checklist
Before we can review and merge your changes, please go through the checklist below. If you're still working on some items, feel free to submit your pull request as a draft—our CI will help guide you through the remaining steps.
✅ Required checks
[ X] License: I confirm that my changes are submitted under the Apache License, Version 2.0.
[ X] Commit signatures: All commits are signed and verifiable. (See GitHub Docs on Commit Signature Verification).
[ X] Code formatting: The code is formatted according to the project’s style guide.
How to check and fix formatting
./mvnw spotless:check./mvnw spotless:applySee the build instructions for details.
Build & Test: I verified that the project builds and all unit tests pass.
How to build the project
Run:
./mvnw verifySee the build instructions for details.
🧪 Tests (select one)
📝 Changelog (select one)
src/changelog/.2.x.x. (See Changelog Entry File Guide).