Skip to content

Commit 970bacb

Browse files
committed
Add more suppressions and remove unused imports
1 parent c740d24 commit 970bacb

File tree

8 files changed

+11
-9
lines changed

8 files changed

+11
-9
lines changed

dev/checkstyle/suppressions.xml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,14 @@
130130
<suppress checks="RegexpMultilineCheck" files="src/test/java/org/apache/sysds/test/functions/transform/TransformFrameEncodeBagOfWords\.java$"/>
131131
<suppress checks="RegexpMultilineCheck" files="src/test/java/org/apache/sysds/test/gpu/cudaSupportFunctions/CudaCublasGeamTest\.java$"/>
132132
<suppress checks="RegexpMultilineCheck" files="src/test/java/org/apache/sysds/test/gpu/cudaSupportFunctions/CudaCusparseCsrGemmTest\.java$"/>
133+
<suppress checks="RegexpMultilineCheck" files="src/main/java/org/apache/sysds/runtime/einsum/EOpNodeBinary\.java$"/>
134+
<suppress checks="RegexpMultilineCheck" files="src/main/java/org/apache/sysds/runtime/einsum/EOpNodeData\.java$"/>
135+
<suppress checks="RegexpMultilineCheck" files="src/main/java/org/apache/sysds/runtime/einsum/EOpNodeFuse\.java$"/>
136+
<suppress checks="RegexpMultilineCheck" files="src/main/java/org/apache/sysds/runtime/einsum/EOpNodeUnary\.java$"/>
137+
<suppress checks="RegexpMultilineCheck" files="src/main/java/org/apache/sysds/runtime/einsum/EOpNode\.java$"/>
138+
<suppress checks="RegexpMultilineCheck" files="src/main/java/org/apache/sysds/runtime/instructions/cp/EinsumCPInstruction\.java$"/>
139+
<suppress checks="RegexpMultilineCheck" files="src/main/java/org/apache/sysds/runtime/matrix/data/LibMatrixMult\.java$"/>
140+
<suppress checks="RegexpMultilineCheck" files="src/test/java/org/apache/sysds/test/functions/einsum/EinsumTest\.java$"/>
133141

134142
<!-- LocalVariableNameCheck -->
135143
<suppress checks="LocalVariableNameCheck" files="src/main/java/org/apache/sysds/api/PythonDMLScript\.java$"/>
@@ -350,6 +358,8 @@
350358
<suppress checks="MethodNameCheck" files="src/test/java/org/apache/sysds/test/gpu/nn/DNNOperationsGPUTest\.java$"/>
351359
<suppress checks="MethodNameCheck" files="src/test/java/org/apache/sysds/test/usertest/UserInterfaceTest\.java$"/>
352360
<suppress checks="MethodNameCheck" files="src/test/java/org/apache/sysds/test/usertest/pythonapi/StartupTest\.java$"/>
361+
<suppress checks="MethodNameCheck" files="src/main/java/org/apache/sysds/runtime/einsum/EOpNodeBinary\.java$"/>
362+
<suppress checks="MethodNameCheck" files="src/main/java/org/apache/sysds/runtime/einsum/EinsumSpoofRowwise\.java$"/>
353363

354364
<!-- MemberNameCheck -->
355365
<!--<suppress checks="MemberNameCheck" files="src/main/java/org/apache/sysds/api/mlcontext/FrameMetadata\.java$"/>

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,7 @@
375375
<execution>
376376
<id>checkstyle</id>
377377
<!-- runs on mvn test -->
378-
<phase>validate</phase>
378+
<phase>test</phase>
379379
<goals>
380380
<goal>check</goal>
381381
</goals>

src/main/java/org/apache/sysds/runtime/controlprogram/caching/CacheableData.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
import org.apache.sysds.runtime.compress.CompressedMatrixBlock;
4444
import org.apache.sysds.runtime.controlprogram.caching.LazyWriteBuffer.RPolicy;
4545
import org.apache.sysds.runtime.controlprogram.federated.FederationMap;
46-
import org.apache.sysds.runtime.controlprogram.parfor.LocalTaskQueue;
4746
import org.apache.sysds.runtime.controlprogram.parfor.util.IDSequence;
4847
import org.apache.sysds.runtime.instructions.cp.Data;
4948
import org.apache.sysds.runtime.instructions.fed.InitFEDInstruction;

src/main/java/org/apache/sysds/runtime/controlprogram/caching/FrameObject.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@
3333
import org.apache.sysds.runtime.controlprogram.federated.FederatedRange;
3434
import org.apache.sysds.runtime.controlprogram.federated.FederatedResponse;
3535
import org.apache.sysds.runtime.controlprogram.federated.FederationMap;
36-
import org.apache.sysds.runtime.controlprogram.parfor.LocalTaskQueue;
3736
import org.apache.sysds.runtime.frame.data.FrameBlock;
3837
import org.apache.sysds.runtime.instructions.ooc.OOCStream;
3938
import org.apache.sysds.runtime.instructions.spark.data.IndexedMatrixValue;

src/main/java/org/apache/sysds/runtime/einsum/EOpNode.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@
2121

2222
import org.apache.commons.logging.Log;
2323
import org.apache.sysds.runtime.matrix.data.MatrixBlock;
24-
import scala.Int;
2524

2625
import java.util.ArrayList;
2726
import java.util.Arrays;

src/main/java/org/apache/sysds/runtime/einsum/EOpNodeFuse.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@
3434
import org.jetbrains.annotations.NotNull;
3535

3636
import java.util.ArrayList;
37-
import java.util.Arrays;
3837
import java.util.Comparator;
3938
import java.util.HashMap;
4039
import java.util.HashSet;

src/main/java/org/apache/sysds/runtime/einsum/EOpNodeUnary.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@
2020
package org.apache.sysds.runtime.einsum;
2121

2222
import org.apache.commons.logging.Log;
23-
import org.apache.sysds.common.Opcodes;
2423
import org.apache.sysds.common.Types;
25-
import org.apache.sysds.hops.AggUnaryOp;
26-
import org.apache.sysds.hops.rewrite.HopRewriteUtils;
2724
import org.apache.sysds.runtime.functionobjects.DiagIndex;
2825
import org.apache.sysds.runtime.functionobjects.KahanPlus;
2926
import org.apache.sysds.runtime.functionobjects.Plus;

src/main/java/org/apache/sysds/runtime/instructions/ooc/OOCStream.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
package org.apache.sysds.runtime.instructions.ooc;
2121

2222
import org.apache.sysds.runtime.DMLRuntimeException;
23-
import org.apache.sysds.runtime.controlprogram.parfor.LocalTaskQueue;
2423

2524
import java.util.function.Consumer;
2625

0 commit comments

Comments
 (0)