This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
25 | 25 |
| |
26 | 26 |
| |
27 | 27 |
| |
28 |
| - | |
| 28 | + | |
29 | 29 |
| |
30 | 30 |
| |
31 | 31 |
| |
|
3 commit comments
macegr commentedon Oct 17, 2016
This was not a good thing to do. It opens the door for some very sneaky bugs. For example, it stops throwing an error when a pointer is cast to a non-pointer type.
cmaglie commentedon Oct 17, 2016
The reason for this has already been discussed here and following comments.
macegr commentedon Oct 17, 2016
The comment was sparked by this discussion: https://www.reddit.com/r/arduino/comments/57h8j1/invalid_conversion_from_unsigned_char_to_int/
The Arduino IDE currently defaults to show NO compiler warnings. It is unrealistic to assume that any incorrectly-written libraries will be corrected as long as the IDE silently hides these problems. New Arduino builds have broken existing libraries since time immemorial and they will get fixed. But not while the errors are hidden, as well as the warnings.
Here is where the default compiler warning level is set to none:
Arduino/app/src/cc/arduino/view/preferences/Preferences.java
Line 820 in 2bfe164