Skip to content

Commit 615ee2d

Browse files
authored
feat(rds): specify PreferredMaintenanceWindow in reader or writer props (#29686)
### Issue #29687 Closes ##29687 ### Reason for this change Since `instanceProps` is deprecated it is better to allow setting `PreferredMaintenanceWindow` using writer and readers props. ### Description of changes Added optional preferredMaintenanceWindow field to ClusterInstanceOptions and added a unit test. ### Description of how you validated changes - Add a single unit test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 parent 2814011 commit 615ee2d

File tree

12 files changed

+237
-141
lines changed

12 files changed

+237
-141
lines changed

packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster.js.snapshot/aws-cdk-rds-integ-with-feature-flag.assets.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster.js.snapshot/aws-cdk-rds-integ-with-feature-flag.template.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -536,6 +536,7 @@
536536
"Ref": "DatabaseSubnets56F17B9A"
537537
},
538538
"Engine": "aurora-mysql",
539+
"PreferredMaintenanceWindow": "Sat:22:15-Sat:22:45",
539540
"PubliclyAccessible": true
540541
},
541542
"DependsOn": [
@@ -569,6 +570,7 @@
569570
"Ref": "DatabaseSubnets56F17B9A"
570571
},
571572
"Engine": "aurora-mysql",
573+
"PreferredMaintenanceWindow": "Sat:22:15-Sat:22:45",
572574
"PubliclyAccessible": true
573575
},
574576
"DependsOn": [
@@ -602,6 +604,7 @@
602604
"Ref": "DatabaseSubnets56F17B9A"
603605
},
604606
"Engine": "aurora-mysql",
607+
"PreferredMaintenanceWindow": "Sat:22:15-Sat:22:45",
605608
"PubliclyAccessible": true
606609
},
607610
"DependsOn": [

packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster.js.snapshot/aws-cdk-rds-integ.assets.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster.js.snapshot/aws-cdk-rds-integ.template.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -536,6 +536,7 @@
536536
"Ref": "DatabaseSubnets56F17B9A"
537537
},
538538
"Engine": "aurora-mysql",
539+
"PreferredMaintenanceWindow": "Sat:22:15-Sat:22:45",
539540
"PubliclyAccessible": true
540541
},
541542
"DependsOn": [
@@ -547,7 +548,7 @@
547548
"UpdateReplacePolicy": "Delete",
548549
"DeletionPolicy": "Delete"
549550
},
550-
"DatabaseInstanceParameterGroup6968C5BF": {
551+
"DatabaseInstance2WrapperInstanceParameterGroup61FBD67B": {
551552
"Type": "AWS::RDS::DBParameterGroup",
552553
"Properties": {
553554
"Description": "Parameter group for aurora-mysql8.0",
@@ -563,12 +564,13 @@
563564
},
564565
"DBInstanceClass": "db.t3.medium",
565566
"DBParameterGroupName": {
566-
"Ref": "DatabaseInstanceParameterGroup6968C5BF"
567+
"Ref": "DatabaseInstance2WrapperInstanceParameterGroup61FBD67B"
567568
},
568569
"DBSubnetGroupName": {
569570
"Ref": "DatabaseSubnets56F17B9A"
570571
},
571572
"Engine": "aurora-mysql",
573+
"PreferredMaintenanceWindow": "Sat:22:15-Sat:22:45",
572574
"PubliclyAccessible": true
573575
},
574576
"DependsOn": [

packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster.js.snapshot/cdk.out

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster.js.snapshot/integ.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/@aws-cdk-testing/framework-integ/test/aws-rds/test/integ.cluster.js.snapshot/manifest.json

Lines changed: 15 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)