-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(ec2): support the new ServiceRegion
property for AWS::EC2::VPCEndpoint
#35025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
4f44901
to
465704d
Compare
Clarification request I believe the failed build is expected since the new snapshot doesn't match the current one. |
Exemption request I believe the failed build is expected since the new snapshot doesn't match the current one. Is anyone able to help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @richarddotcodes , Thank you for your contribution!
You are correct that the build fails due to integration test snapshots not being updated. However, this change should be done and committed on this PR.
If you can, follow this guide to run and update the integration snapshots, which suggests to run the following to update the snapshots:
yarn integ-runner --directory packages/@aws-cdk --update-on-failed
The snapshots will then be updated. Commit those changes once this is done.
2c1ec03
to
ba0c017
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
@Abogical Thanks for the help! I've submitted the snapshot changes and the build is now passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
@Mergifyio rebase |
67f57c4
to
522c588
Compare
✅ Branch has been successfully rebased |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #32785
Reason for this change
Supporting the new L1 property in the L2 construct.
AWS::EC2::VPCEndpointService
support was added in #33959, so this should complete support for cross-region vpc private links.Description of changes
Added a new L2 prop -
serviceRegion
- which is of typestring
. It gets passed to the L1ServiceRegion
property when present.Describe any new or updated permissions being added
None
Description of how you validated changes
Added unit tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license