Skip to content

Conversation

richarddotcodes
Copy link
Contributor

Issue # (if applicable)

Closes #32785

Reason for this change

Supporting the new L1 property in the L2 construct. AWS::EC2::VPCEndpointService support was added in #33959, so this should complete support for cross-region vpc private links.

Description of changes

Added a new L2 prop - serviceRegion - which is of type string. It gets passed to the L1 ServiceRegion property when present.

Describe any new or updated permissions being added

None

Description of how you validated changes

Added unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team July 21, 2025 23:15
@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p1 labels Jul 21, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@richarddotcodes
Copy link
Contributor Author

Clarification request

I believe the failed build is expected since the new snapshot doesn't match the current one.

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Jul 22, 2025
@richarddotcodes
Copy link
Contributor Author

@aws-cdk-automation aws-cdk-automation removed the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Jul 29, 2025
@richarddotcodes
Copy link
Contributor Author

Exemption request

I believe the failed build is expected since the new snapshot doesn't match the current one. Is anyone able to help?

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jul 29, 2025
@Abogical Abogical self-assigned this Aug 4, 2025
Copy link
Member

@Abogical Abogical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @richarddotcodes , Thank you for your contribution!

You are correct that the build fails due to integration test snapshots not being updated. However, this change should be done and committed on this PR.

If you can, follow this guide to run and update the integration snapshots, which suggests to run the following to update the snapshots:

yarn integ-runner --directory packages/@aws-cdk --update-on-failed

The snapshots will then be updated. Commit those changes once this is done.

@richarddotcodes richarddotcodes force-pushed the cross-region-in-progress branch from 2c1ec03 to ba0c017 Compare August 4, 2025 17:38
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 4, 2025 17:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@richarddotcodes
Copy link
Contributor Author

@Abogical Thanks for the help! I've submitted the snapshot changes and the build is now passing.

@mergify mergify bot dismissed Abogical’s stale review August 5, 2025 18:18

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 5, 2025
Copy link
Member

@Abogical Abogical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

mergify bot commented Aug 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 6, 2025
Copy link
Contributor

mergify bot commented Aug 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Aug 6, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@Abogical
Copy link
Member

Abogical commented Aug 6, 2025

@Mergifyio update

Copy link
Contributor

mergify bot commented Aug 6, 2025

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@Abogical
Copy link
Member

Abogical commented Aug 6, 2025

@Mergifyio rebase

@Abogical Abogical force-pushed the cross-region-in-progress branch from 67f57c4 to 522c588 Compare August 6, 2025 14:50
Copy link
Contributor

mergify bot commented Aug 6, 2025

rebase

✅ Branch has been successfully rebased

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 522c588
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Aug 6, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit fee0638 into aws:main Aug 6, 2025
19 checks passed
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2025
@richarddotcodes richarddotcodes deleted the cross-region-in-progress branch August 7, 2025 15:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-ec2: Support Cross-Region VPC Private Links
3 participants