-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix(signer): not correctly passing signingProfileName to CfnSigningProfile #35033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
…ngProfile (under feature flag)
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks. You may have to fix your CI before adding the pull request to the queue again. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #35030.
Reason for this change
The
signingProfileName
property set in the AWS CDK's Signer module L2 construct is not being properly propagated to the generated L1 CloudFormation template. This causes AWS Signer profiles to be created without the specified name, which leads to unexpected behavior and difficulty in managing resources.Description of changes
SigningProfile
class constructor to passthis.physicalName
to the L1CfnSigningProfile
resource'sprofileName
propertyProfileName
property is correctly included in the CloudFormation template whensigningProfileName
is provided, and absent when not providedThese changes ensure that when a user specifies a
signingProfileName
, it will be included in the generated CloudFormation template as theProfileName
property. The fix maintains backward compatibility and doesn't introduce any breaking changes to the API.Describe any new or updated permissions being added
No new or updated IAM permissions are needed for this change.
Description of how you validated changes
Why we need a FF to avoid BC
If we had specified a
signingProfileName
in their SigningProfile construct, the CloudFormation template will now include this name as the ProfileName property.Previously, this name was ignored in the CloudFormation template, causing CloudFormation to auto-generate a name for the signing profile.
Upon deployment with the updated CDK version, CloudFormation will detect this as a change and will:
Create a new signing profile with the specified name.
Delete the old signing profile that had an auto-generated name
This replacement of the signing profile can break existing references to the profile and disrupt workflows that depend on the existing profile hence this PR introduced a FF to avoid this.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license