Skip to content

Commit 0135f9e

Browse files
authored
🐛 fix(nav): adjust overview links and popup (#1242)
* fix(nav): adjust overview links and popup * chore(): update base images * chore(): update base images * chore: trigger build --------- Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
1 parent eae0fbe commit 0135f9e

23 files changed

Lines changed: 47 additions & 14 deletions

.changeset/sweet-hairs-admire.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@baloise/design-system-components': patch
3+
---
4+
5+
Add missing `` sign to the overview links in the `bal-nav` component and adjust padding and height of the `bal-popup` component in fullscreen variant.

CHANGELOG_NEXT.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,6 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline
399399
* **tabs:** add hidden, spaceless and float ([bed5b37](https://github.com/baloise/design-system/commit/bed5b37cd398f6fe842d3756ab2b23243daa462b))
400400
* **tabs:** add hidden, spaceless and float ([1111288](https://github.com/baloise/design-system/commit/1111288f66f137e6ad68d2aeb8afce8e66d4dc75))
401401

402-
403402
### Bug Fixes
404403

405404
* **button:** adjust start height to 48px ([1b11e1b](https://github.com/baloise/design-system/commit/1b11e1b18bdccf2f73231fd32921b98b2ef8f395))

packages/components/src/components/bal-nav/bal-nav.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -458,7 +458,7 @@ export class NavMetaBar
458458
target={this.activeMenuLinkItem?.overviewLink?.target}
459459
onClick={() => this.linkItemClickListener(this.activeMenuLinkItem?.overviewLink)}
460460
>
461-
{this.activeMenuLinkItem?.overviewLink?.label}
461+
{this.activeMenuLinkItem?.overviewLink?.label}
462462
</bal-nav-link>
463463
{this.renderGridLinks(this.activeMenuLinkItem)}
464464
</bal-nav-menu-flyout>

packages/components/src/components/bal-nav/components/overview-link.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export const OverviewLink: FunctionalComponent<OverviewLinkProps> = ({ item, isM
2525
target={item.target}
2626
onClick={ev => onClick(ev)}
2727
>
28-
{item.label}
28+
{item.label}
2929
</a>
3030
)
3131
}

packages/components/src/components/bal-nav/test/bal-nav.visual.html

Lines changed: 36 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,34 @@
4444
inventore vel nesciunt. Exercitationem totam doloribus reiciendis quae magni eius ipsa. Inventore sit
4545
placeat modi suscipit laborum quisquam laudantium!
4646
</p>
47+
<p>
48+
Lorem ipsum dolor sit, amet consectetur adipisicing elit. Quis qui vero nulla vitae nemo harum laborum
49+
iusto voluptate. Enim facilis quod iste dolores sit quidem aspernatur molestias itaque consequatur
50+
nostrum? Laborum odio accusantium repudiandae ipsa? Expedita corrupti similique sint aspernatur officiis
51+
inventore vel nesciunt. Exercitationem totam doloribus reiciendis quae magni eius ipsa. Inventore sit
52+
placeat modi suscipit laborum quisquam laudantium!
53+
</p>
54+
<p>
55+
Lorem ipsum dolor sit, amet consectetur adipisicing elit. Quis qui vero nulla vitae nemo harum laborum
56+
iusto voluptate. Enim facilis quod iste dolores sit quidem aspernatur molestias itaque consequatur
57+
nostrum? Laborum odio accusantium repudiandae ipsa? Expedita corrupti similique sint aspernatur officiis
58+
inventore vel nesciunt. Exercitationem totam doloribus reiciendis quae magni eius ipsa. Inventore sit
59+
placeat modi suscipit laborum quisquam laudantium!
60+
</p>
61+
<p>
62+
Lorem ipsum dolor sit, amet consectetur adipisicing elit. Quis qui vero nulla vitae nemo harum laborum
63+
iusto voluptate. Enim facilis quod iste dolores sit quidem aspernatur molestias itaque consequatur
64+
nostrum? Laborum odio accusantium repudiandae ipsa? Expedita corrupti similique sint aspernatur officiis
65+
inventore vel nesciunt. Exercitationem totam doloribus reiciendis quae magni eius ipsa. Inventore sit
66+
placeat modi suscipit laborum quisquam laudantium!
67+
</p>
68+
<p>
69+
Lorem ipsum dolor sit, amet consectetur adipisicing elit. Quis qui vero nulla vitae nemo harum laborum
70+
iusto voluptate. Enim facilis quod iste dolores sit quidem aspernatur molestias itaque consequatur
71+
nostrum? Laborum odio accusantium repudiandae ipsa? Expedita corrupti similique sint aspernatur officiis
72+
inventore vel nesciunt. Exercitationem totam doloribus reiciendis quae magni eius ipsa. Inventore sit
73+
placeat modi suscipit laborum quisquam laudantium!
74+
</p>
4775
</bal-popup>
4876

4977
<bal-popup id="popup-login" label="Anmelden" content-width="440">
@@ -249,8 +277,8 @@ <h2 class="title is-size-xx-large mb-normal">Heading</h2>
249277
href: 'http://localhost:3333/components/bal-nav/test/bal-nav.visual.html',
250278
active: true,
251279
overviewLink: {
252-
value: 'Privatkunden',
253-
label: 'Privatkunden',
280+
value: 'Privatkunden',
281+
label: 'Privatkunden',
254282
href: 'http://localhost:3333/components/bal-nav/test/bal-nav.visual.html',
255283
},
256284
mainLinkItems: [
@@ -436,8 +464,8 @@ <h2 class="title is-size-xx-large mb-normal">Heading</h2>
436464
},
437465
],
438466
overviewLink: {
439-
value: 'Alle Versicherungslösungen',
440-
label: 'Alle Versicherungslösungen',
467+
value: 'Alle Versicherungslösungen',
468+
label: 'Alle Versicherungslösungen',
441469
href: 'http://localhost:3333/components/bal-nav/test/bal-nav.visual.html',
442470
},
443471
},
@@ -640,8 +668,8 @@ <h2 class="title is-size-xx-large mb-normal">Heading</h2>
640668
},
641669
],
642670
overviewLink: {
643-
value: 'Alle Anlage- und Vorsorgelösungen',
644-
label: 'Alle Anlage- und Vorsorgelösungen',
671+
value: 'Alle Anlage- und Vorsorgelösungen',
672+
label: 'Alle Anlage- und Vorsorgelösungen',
645673
href: 'http://localhost:3333/components/bal-nav/test/bal-nav.visual.html',
646674
},
647675
},
@@ -731,8 +759,8 @@ <h2 class="title is-size-xx-large mb-normal">Heading</h2>
731759
},
732760
],
733761
overviewLink: {
734-
value: 'Alle Bankprodukte',
735-
label: 'Alle Bankprodukte',
762+
value: 'Alle Bankprodukte',
763+
label: 'Alle Bankprodukte',
736764
href: 'http://localhost:3333/components/bal-nav/test/bal-nav.visual.html',
737765
},
738766
},

packages/components/src/components/bal-popup/bal-popup.sass

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,9 @@
3636
min-width: 100%
3737
max-width: 100% !important
3838
min-height: var(--bal-app-height, 100%)
39-
padding-left: var(--bal-container-space)
40-
padding-right: var(--bal-container-space)
39+
.bal-popup__inner
40+
padding-left: var(--bal-container-space)
41+
padding-right: var(--bal-container-space)
4142
&--variant-drawer
4243
position: fixed
4344
border-top-left-radius: var(--bal-popup-variant-drawer-radius)
@@ -51,7 +52,7 @@
5152
5253
.bal-popup__inner
5354
overflow-y: auto
54-
max-height: calc(var(--bal-app-height, 100%) - 8rem)
55+
max-height: calc(var(--bal-app-height, 100%) - 4rem)
5556

5657
// Popup Head
5758
// --------------------------------------------------
-3 Bytes
Loading
-17 Bytes
Loading
-67 Bytes
Loading
51 KB
Loading

0 commit comments

Comments
 (0)