Skip to content

Commit a692194

Browse files
🐛 fix(field): horizontal padding right and label text alignment (#1260)
* Create PR for #1259 * fix(field): remove padding and align label * chore(): update base images * chore: trigger build * chore(): update base images * chore: trigger build --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch> Co-authored-by: hirsch88 <hirsch88@users.noreply.github.com>
1 parent b5ccbbb commit a692194

20 files changed

Lines changed: 13 additions & 6 deletions

.changeset/proud-houses-promise.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@baloise/design-system-components': patch
3+
---
4+
5+
The horizontal form field now lacks right padding, and the label is aligned to the right.

CHANGELOG_NEXT.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1101,7 +1101,6 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline
11011101

11021102
## [10.17.2](https://github.com/baloise/design-system/compare/v10.17.1...v10.17.2) (2022-08-11)
11031103

1104-
11051104
### Features
11061105

11071106
* **nav desktop:** updated dependencies ([7b517a9](https://github.com/baloise/design-system/commit/7b517a950d3823b5c9134bef3dee036c031ffc99))

CHANGELOG_v12.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,6 @@ Follow the migration guide [Migration from 11.x to 12.x](https://baloise-design-
303303
* update @baloise/web-app-utils to solve safari 13 issues ([43c5b13](https://github.com/baloise/design-system/commit/43c5b132b4089346a132dbbda34c15b86860735a))
304304
* update web-app-utils ([c1dc7e3](https://github.com/baloise/design-system/commit/c1dc7e35250293a9f55fabbcb2ff33507e13b7f7))
305305

306-
307306
### Performance Improvements
308307

309308
* reduce web-app-utils imports ([7c3a21f](https://github.com/baloise/design-system/commit/7c3a21f3d995c3096c0ef23498936ddd6d9b9e3b))

packages/components/src/components/bal-field/bal-field.sass

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@
2323
+block(field-message)
2424
line-height: var(--bal-line-height-normal)
2525

26+
+block(field-hidden)
27+
+hide-element
28+
2629
+block(field-control)
2730
display: flex
2831
align-items: center
@@ -57,8 +60,9 @@
5760
min-width: var(--bal-field-label-horizontal-width)
5861
max-width: var(--bal-field-label-horizontal-width)
5962
justify-content: end
63+
text-align: right
6064
margin-bottom: 0
61-
65+
6266
.bal-field-control
6367
flex: 1
6468
padding-bottom: 0
@@ -75,5 +79,5 @@
7579
.bal-hint
7680
top: 0
7781

78-
.bal-field-hint ~ .bal-field-message
79-
margin-left: calc(var(--bal-field-label-horizontal-width) + (var(--bal-field-label-column-gap) * 2) + 1.125rem)
82+
.bal-field-hint ~ .bal-field-message
83+
margin-left: calc(var(--bal-field-label-horizontal-width) + (var(--bal-field-label-column-gap) * 2) + 1.125rem)

packages/components/src/components/bal-field/bal-field.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ export class Field implements ComponentInterface, BalMutationObserver {
203203
}}
204204
>
205205
<slot></slot>
206-
<span class="hidden">{/* Empty slot element to keep the order of the children */}</span>
206+
<span class="bal-field-hidden">{/* Empty slot element to keep the order of the children */}</span>
207207
</Host>
208208
)
209209
}
171 Bytes
Loading
89 Bytes
Loading
121 Bytes
Loading
-1 KB
Loading
-6.69 KB
Loading

0 commit comments

Comments
 (0)