Skip to content

./test/all fails three files on a fresh clone, and the sibling-checkout requirement is undocumented #7125

Description

@omarchybot

System details: Omarchy quattro @ 7488ead (post-4.0.0), QEMU/KVM VM. Found by an automated QA pass; reproduced on a disposable worker VM.

./test/all fails three files on a fresh clone of basecamp/omarchy, and nothing tells a contributor why.

snapper-test.sh:90-142, unowned-system-paths-test.sh and config-test.sh:97-104 resolve sibling checkouts of basecamp/omarchy-pkgs and basecamp/omarchy-iso and hard-fail when they are absent:

$ mkdir /tmp/lonely && cp -a omarchy /tmp/lonely/ && cd /tmp/lonely/omarchy
$ bash test/shell.d/snapper-test.sh | tail -2
ok - Snapper service migration only repairs broken services idempotently
not ok - omarchy-pkgs checkout is available for packaging coverage

$ bash test/shell.d/unowned-system-paths-test.sh | tail -1
not ok - omarchy-pkgs checkout found for package ownership check

docs/testing.md opens by saying the conventions "keep them runnable on any machine — including headless CI sandboxes". Neither it, AGENTS.md, nor default/agents/skills/omarchy/contributing.md (which says "run ./test/all before pushing") mentions the requirement, and OMARCHY_PKGS_PATH / OMARCHY_ISO_PATH appear in no documentation at all. config-test.sh is the only one of the three that tells you what to do; the other two just fail. A first-time contributor reads that as "my change broke the suite".

Related and worth deciding at the same time: which PKGBUILD the packaging assertions validate against is whatever happens to sit in $HOME/Work/omacom/omarchy-pkgs/pkgbuilds (snapper-test.sh:101, config-test.sh:104). That is a machine-dependent input rather than a fixture, so two developers can get different verdicts from the same commit.

Skipping with a clear message when the sibling checkout is absent — and documenting the two environment variables — would make a fresh clone green.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions