Remove storage root verification

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

Author: mirgee

ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/snapsync/request/BlockAccessListDataRequest.java

@@ -26,7 +26,6 @@
 import org.hyperledger.besu.ethereum.rlp.RLP;
 import org.hyperledger.besu.ethereum.trie.common.PmtStateTrieAccountValue;
 import org.hyperledger.besu.ethereum.trie.pathbased.bonsai.storage.BonsaiWorldStateKeyValueStorage;
-import org.hyperledger.besu.ethereum.trie.pathbased.common.worldview.PathBasedWorldView;
 import org.hyperledger.besu.ethereum.trie.patricia.StoredMerklePatriciaTrie;
 import org.hyperledger.besu.ethereum.worldstate.WorldStateStorageCoordinator;
 import org.hyperledger.besu.plugin.services.storage.WorldStateKeyValueStorage;
@@ -101,12 +100,7 @@ protected int doPersist(
 
             final Hash updatedStorageRoot = currentValue.getStorageRoot();
             if (!accountChanges.storageChanges().isEmpty()) {
-              applyStorageChangesAndVerifyStorageRoot(
-                  accountHash,
-                  updatedStorageRoot,
-                  accountChanges,
-                  worldStateStorageCoordinator,
-                  bonsaiUpdater);
+              applyStorageChanges(accountHash, accountChanges, bonsaiUpdater);
             }
 
             final PmtStateTrieAccountValue updatedValue =
@@ -122,44 +116,20 @@ protected int doPersist(
     return 0;
   }
 
-  private void applyStorageChangesAndVerifyStorageRoot(
+  private void applyStorageChanges(
       final Hash accountHash,
-      final Hash expectedStorageRoot,
       final BlockAccessListChanges.AccountFinalChanges accountChanges,
-      final WorldStateStorageCoordinator worldStateStorageCoordinator,
       final BonsaiWorldStateKeyValueStorage.Updater bonsaiUpdater) {
-    final StoredMerklePatriciaTrie<Bytes, Bytes> storageTrie =
-        new StoredMerklePatriciaTrie<>(
-            (location, hash) ->
-                worldStateStorageCoordinator.getAccountStorageTrieNode(accountHash, location, hash),
-            Bytes32.wrap(expectedStorageRoot.getBytes()),
-            value -> value,
-            value -> value);
-
     for (final var storageChange : accountChanges.storageChanges()) {
       final Hash slotHash = storageChange.slot().getSlotHash();
       final UInt256 value = storageChange.value();
-      final Bytes slotKey = slotHash.getBytes();
 
       if (value.equals(UInt256.ZERO)) {
         bonsaiUpdater.removeStorageValueBySlotHash(accountHash, slotHash);
-        storageTrie.remove(slotKey);
       } else {
         bonsaiUpdater.putStorageValueBySlotHash(accountHash, slotHash, value.toBytes());
-        storageTrie.put(slotKey, PathBasedWorldView.encodeTrieValue(value.toBytes()));
       }
     }
-
-    final Hash calculatedStorageRoot = Hash.wrap(storageTrie.getRootHash());
-    if (!calculatedStorageRoot.equals(expectedStorageRoot)) {
-      throw new IllegalStateException(
-          "Storage root mismatch for account "
-              + accountHash
-              + ": expected "
-              + expectedStorageRoot
-              + " but got "
-              + calculatedStorageRoot);
-    }
   }
 
   @Override