Update ethereum/core/src/main/java/org/hyperledger/besu/ethereum/vm/DebugOperationTracer.java

Call lastFrame.getMemory() only once

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>

Author: daniellehrner

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/vm/DebugOperationTracer.java

@@ -245,12 +245,13 @@ private Optional<Map<UInt256, UInt256>> captureStorage(final MessageFrame frame)
   private Optional<Bytes[]> captureMemory(final MessageFrame frame) {
     if (!options.traceMemory() || frame.memoryWordSize() == 0) {
       return Optional.empty();
-    } else if (frame.getMaybeUpdatedMemory().isEmpty()
-        && lastFrame != null
-        && lastFrame.getDepth() == frame.getDepth()
-        && lastFrame.getMemory().isPresent()
-        && lastFrame.getMemory().get().length == frame.memoryWordSize()) {
-      return lastFrame.getMemory();
+    } else if (frame.getMaybeUpdatedMemory().isEmpty() && lastFrame != null) {
+      final Optional<Bytes[]> lastMemory = lastFrame.getMemory();
+      if (lastFrame.getDepth() == frame.getDepth()
+          && lastMemory.isPresent()
+          && lastMemory.get().length == frame.memoryWordSize()) {
+        return lastMemory;
+      }
     }
     return forceCaptureMem(frame);
   }