Commit 8d89458
Fix flaky BackwardSyncContextTest on slow CI runners (#10000)
shouldSyncUntilHash and shouldSyncUntilRemoteBranch used isCompleted()
inside untilAsserted, which only passes for normal completion. On slow CI
machines the backward sync occasionally completes the future exceptionally,
causing isCompleted() to fail on every retry until the 30s Awaitility
timeout, which then rethrows the AssertionError.
Change to isDone() inside the Awaitility block (matching the fix applied
to shouldAddExpectedBlock in #9856) so Awaitility exits as soon as the
future reaches any terminal state. The subsequent future.get() will then
surface the real exception if the sync failed.
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>1 parent 28c8a86 commit 8d89458
File tree
1 file changed
+3
-3
lines changed- ethereum/eth/src/test/java/org/hyperledger/besu/ethereum/eth/sync/backwardsync
1 file changed
+3
-3
lines changedLines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
303 | 303 | | |
304 | 304 | | |
305 | 305 | | |
306 | | - | |
| 306 | + | |
307 | 307 | | |
308 | 308 | | |
309 | 309 | | |
| |||
337 | 337 | | |
338 | 338 | | |
339 | 339 | | |
340 | | - | |
| 340 | + | |
341 | 341 | | |
342 | 342 | | |
343 | | - | |
| 343 | + | |
344 | 344 | | |
345 | 345 | | |
346 | 346 | | |
| |||
0 commit comments