Change Maven artifactIds to avoid possible collisions with other libs (#8589)

* Improve Maven artifacts naming to avoid possible collisions with other libs

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>

Author: fab-10

CHANGELOG.md

@@ -1,6 +1,8 @@
 # Changelog
 ## Unreleased
 ### Breaking Changes
+- Changes in Maven coordinates of Besu artifacts to avoid possible collisions with other libraries when packaging plugins [#8589](https://github.com/hyperledger/besu/pull/8589)
+
 ### Upcoming Breaking Changes
 ### Additions and Improvements
 #### Fusaka Devnet

acceptance-tests/dsl/build.gradle

@@ -1,3 +1,18 @@
+apply plugin: 'java-library'
+
+jar {
+  archiveBaseName = calculateArtifactId(project)
+  manifest {
+    attributes(
+      'Specification-Title': archiveBaseName,
+      'Specification-Version': project.version,
+      'Implementation-Title': archiveBaseName,
+      'Implementation-Version': calculateVersion(),
+      'Commit-Hash': getGitCommitDetails(40).hash
+      )
+  }
+}
+
 dependencies {
   implementation project(':besu')
   implementation project(':config')

besu/build.gradle

@@ -16,7 +16,7 @@
 apply plugin: 'java-library'
 
 jar {
-  archiveBaseName = 'besu'
+  archiveBaseName = calculateArtifactId(project)
   manifest {
     attributes(
       'Specification-Title': archiveBaseName,

build.gradle

@@ -460,7 +460,7 @@ task checkMavenCoordinateCollisions {
           if (coordinate.toString().startsWith("org") && coordinates.containsKey(coordinate)) {
             throw new GradleException("Duplicate maven coordinates detected, ${coordinate} is used by " +
             "both ${coordinates[coordinate]} and ${it.path}.\n" +
-            "Please add a `publishing` script block to one or both subprojects.")
+            "Prefer automatic artifactId creation or if not possible disambiguate manually.")
           }
           coordinates[coordinate] = it.path
         }
@@ -491,7 +491,7 @@ subprojects {
     dependencies { testImplementation sourceSets.testSupport.output }
 
     task testSupportJar(type: Jar) {
-      archiveBaseName = "${project.name}-support-test"
+      archiveBaseName = calculateArtifactId(project) + '-support-test'
       archiveClassifier = 'test-support'
       from sourceSets.testSupport.output
     }
@@ -545,6 +545,7 @@ subprojects {
       publications {
         mavenJava(MavenPublication) {
           groupId "org.hyperledger.besu.internal"
+          artifactId calculateArtifactId(project)
           version "${project.version}"
           if (sourceSetIsPopulated("main")) {
             from components.java
@@ -1014,6 +1015,15 @@ def calculateVersion() {
   }
 }
 
+def calculateArtifactId(configuringProject) {
+  def currentProject = configuringProject
+  def projectNames = [currentProject.name]
+  while((currentProject = currentProject.getParent()) != null) {
+    projectNames << currentProject.name
+  }
+  return projectNames.reverse().join('-')
+}
+
 def getGitCommitDetails(length = 8) {
   try {
     def gitFolder = "$projectDir/.git/"

config/build.gradle

@@ -16,7 +16,7 @@
 apply plugin: 'java-library'
 
 jar {
-  archiveBaseName = 'besu-config'
+  archiveBaseName = calculateArtifactId(project)
   manifest {
     attributes(
       'Specification-Title': archiveBaseName,

consensus/clique/build.gradle

@@ -16,7 +16,7 @@
 plugins { id 'java' }
 
 jar {
-  archiveBaseName = 'besu-clique'
+  archiveBaseName = calculateArtifactId(project)
   manifest {
     attributes(
       'Specification-Title': archiveBaseName,

consensus/common/build.gradle

@@ -16,7 +16,7 @@
 apply plugin: 'java-library'
 
 jar {
-  archiveBaseName = 'besu-consensus-common'
+  archiveBaseName = calculateArtifactId(project)
   manifest {
     attributes(
       'Specification-Title': archiveBaseName,
@@ -68,7 +68,7 @@ dependencies {
 
 configurations { testArtifacts }
 task testJar (type: Jar) {
-  archiveBaseName = "${project.name}-test"
+  archiveBaseName = calculateArtifactId(project) + '-test'
   from sourceSets.test.output
 }
 

consensus/ibft/build.gradle

@@ -16,7 +16,7 @@
 apply plugin: 'java-library'
 
 jar {
-  archiveBaseName = 'besu-ibft'
+  archiveBaseName = calculateArtifactId(project)
   manifest {
     attributes(
       'Specification-Title': archiveBaseName,

consensus/ibftlegacy/build.gradle

@@ -1,7 +1,7 @@
 apply plugin: 'java-library'
 
 jar {
-  archiveBaseName = 'besu-ibftlegacy'
+  archiveBaseName = calculateArtifactId(project)
   manifest {
     attributes(
       'Specification-Title': archiveBaseName,

consensus/merge/build.gradle

@@ -16,7 +16,7 @@
 apply plugin: 'java-library'
 
 jar {
-  archiveBaseName = 'besu-merge'
+  archiveBaseName = calculateArtifactId(project)
   manifest {
     attributes(
       'Specification-Title': archiveBaseName,