short circuit getChildRequest in storage and account range requests when the proof is valid and empty (request was complete)

Signed-off-by: garyschulte <garyschulte@gmail.com>

Author: garyschulte

ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/snapsync/request/AccountRangeDataRequest.java

@@ -167,7 +167,17 @@ public Stream<SnapDataRequest> getChildRequests(
       final SnapSyncProcessState snapSyncState) {
     final List<SnapDataRequest> childRequests = new ArrayList<>();
 
+    if (!isProofValid.orElse(false)) {
+      return Stream.empty();
+    }
+
     final StackTrie.TaskElement taskElement = stackTrie.getElement(startKeyHash);
+
+    // if the proof is valid, but there are no entries, that implies the range is complete
+    if (taskElement.proofs().isEmpty()) {
+      return Stream.empty();
+    }
+
     // new request is added if the response does not match all the requested range
     findNewBeginElementInRange(getRootHash(), taskElement.proofs(), taskElement.keys(), endKeyHash)
         .ifPresentOrElse(

ethereum/eth/src/main/java/org/hyperledger/besu/ethereum/eth/sync/snapsync/request/StorageRangeDataRequest.java

@@ -164,6 +164,11 @@ public Stream<SnapDataRequest> getChildRequests(
 
     final StackTrie.TaskElement taskElement = stackTrie.getElement(startKeyHash);
 
+    // if the proof is valid, but there are no entries, that implies the range is complete
+    if (taskElement.proofs().isEmpty()) {
+      return Stream.empty();
+    }
+
     findNewBeginElementInRange(storageRoot, taskElement.proofs(), taskElement.keys(), endKeyHash)
         .ifPresent(
             missingRightElement -> {