Fix save connection handling and cleanup unused code

Author: Erics1337

src/components/tabs/ConfigurationTab.vue

@@ -519,6 +519,8 @@ import FC from "../../js/fc";
 import MSP from "../../js/msp";
 import MSPCodes from "../../js/msp/MSPCodes";
 import { mspHelper } from "../../js/msp/MSPHelper";
+import { reinitializeConnection } from "../../js/serial_backend";
+import { gui_log } from "../../js/gui_log";
 import { i18n } from "../../js/localization";
 import { sensorTypes } from "../../js/sensor_types"; // Import for dropdown lists
 import { have_sensor } from "../../js/sensor_helpers";
@@ -883,6 +885,7 @@ export default defineComponent({
         const saveConfig = async () => {
             try {
                 console.log("Saving configuration...");
+                gui_log("Saving...");
 
                 FC.PID_ADVANCED_CONFIG.gyro_sync_denom = pidAdvancedConfig.gyro_sync_denom;
                 FC.PID_ADVANCED_CONFIG.pid_process_denom = pidAdvancedConfig.pid_process_denom;
@@ -973,13 +976,17 @@ export default defineComponent({
                     );
                 }
 
-                GUI.log(i18n.getMessage("configurationSaved"));
+                gui_log(i18n.getMessage("configurationSaved"));
 
                 // Save to EEPROM and Reboot
-                mspHelper.writeConfiguration(true);
+                mspHelper.writeConfiguration(false, () => {
+                   GUI.tab_switch_cleanup(() => {
+                        reinitializeConnection();
+                   });
+                });
             } catch (e) {
                 console.error("Failed to save configuration", e);
-                GUI.log(i18n.getMessage("configurationSaveFailed"));
+                gui_log(i18n.getMessage("configurationSaveFailed"));
             }
         };
 

src/js/main.js

@@ -13,7 +13,7 @@ import CliAutoComplete from "./CliAutoComplete.js";
 import DarkTheme, { setDarkTheme } from "./DarkTheme.js";
 import { isExpertModeEnabled } from "./utils/isExpertModeEnabled.js";
 import { updateTabList } from "./utils/updateTabList.js";
-import { mountVueTab } from "./vue_tab_mounter.js";
+import { mountVueTab, unmountVueTab } from "./vue_tab_mounter.js";
 import * as THREE from "three";
 import NotificationManager from "./utils/notifications.js";
 
@@ -27,11 +27,7 @@ import("./msp/debug/msp_debug_tools.js")
         console.warn("Failed to load MSP debug tools:", err);
     });
 
-if (typeof String.prototype.replaceAll === "undefined") {
-    String.prototype.replaceAll = function (match, replace) {
-        return this.replace(new RegExp(match, "g"), () => replace);
-    };
-}
+
 
 $(document).ready(function () {
     appReady();
@@ -216,6 +212,7 @@ function startProcess() {
 
                 // detach listeners and remove element data
                 const content = $("#content");
+                unmountVueTab();
                 content.empty();
 
                 // display loading screen

src/js/msp/MSPHelper.js

@@ -14,9 +14,8 @@ import huffmanDecodeBuf from "../huffman";
 import { defaultHuffmanTree, defaultHuffmanLenIndex } from "../default_huffman_tree";
 import { updateTabList } from "../utils/updateTabList";
 import { showErrorDialog } from "../utils/showErrorDialog";
-import GUI, { TABS } from "../gui";
+import GUI from "../gui";
 import { OSD } from "../tabs/osd";
-import { reinitializeConnection } from "../serial_backend";
 
 // Used for LED_STRIP
 const ledDirectionLetters = ["n", "e", "s", "w", "u", "d"]; // in LSB bit order
@@ -2944,7 +2943,7 @@ MspHelper.prototype.writeConfiguration = function (reboot, callback) {
             console.log("Configuration saved to EEPROM");
             if (reboot) {
                 GUI.tab_switch_cleanup(function () {
-                    return reinitializeConnection();
+                    return GUI.reinitializeConnection();
                 });
             }
             if (callback) {

src/js/serial_backend.js

@@ -128,11 +128,7 @@ function connectDisconnect() {
                 return;
             }
 
-            // When rebooting, adhere to the auto-connect setting
-            if (!PortHandler.portPicker.autoConnect && Date.now() - rebootTimestamp < REBOOT_GRACE_PERIOD_MS) {
-                console.log(`${logHead} Rebooting, not connecting`);
-                return;
-            }
+
 
             const portName = selectedPort === "manual" ? PortHandler.portPicker.portOverride : selectedPort;
 
@@ -608,6 +604,7 @@ function finishOpen() {
     onConnect();
 
     GUI.selectDefaultTabWhenConnected();
+    rebootTimestamp = 0;
 }
 
 function connectCli() {
@@ -808,6 +805,9 @@ export function reinitializeConnection() {
     // Send reboot command to the flight controller
     MSP.send_message(MSPCodes.MSP_SET_REBOOT, false, false);
 
+    // Force connection invalid to ensure reboot dialog waits for reconnection
+    CONFIGURATOR.connectionValid = false;
+
     if (currentPort.startsWith("bluetooth")) {
         if (!PortHandler.portPicker.autoConnect) {
             return setTimeout(function () {
@@ -816,14 +816,6 @@ export function reinitializeConnection() {
         }
     }
 
-    // Show reboot progress modal except for cli and presets tab
-    if (["cli", "presets"].includes(GUI.active_tab)) {
-        console.log(`${logHead} Rebooting in ${GUI.active_tab} tab, skipping reboot dialog`);
-        gui_log(i18n.getMessage("deviceRebooting"));
-        gui_log(i18n.getMessage("deviceReady"));
-
-        return;
-    }
     // Show reboot progress modal
     showRebootDialog();
 }
@@ -926,3 +918,5 @@ function showRebootDialog() {
         return dialog;
     }
 }
+
+GUI.reinitializeConnection = reinitializeConnection;

src/js/vue_tab_mounter.js

@@ -63,6 +63,9 @@ export function mountVueTab(tabName, contentReadyCallback) {
         currentTabApp.provide("betaflightModel", window.vm);
     }
 
+    // Set active tab for legacy compatibility
+    GUI.active_tab = tabName;
+
     // Mount to content
     currentTabApp.mount(contentEl);